-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next main #124
Next main #124
Conversation
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Built some testbenches, no issues found.
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think library/ips
might be better named something else, maybe? It's mostly regmap packages and apis for interacting with the dut ips, so not exactly IPs. Similarly, library/xilinx_vip
is sequencers (and I imagine in the future other similar pieces of code) for interacting with testbench VIPs.
So I think they might be renamed something like:
ips
-> dut_wrap
xilinx_vips
-> tb_wrap
Maybe wrapper is not the ideal term?
Co-authored-by: LBFFilho <[email protected]>
Can you please update the TDDN "adi_regmap_tdd_gen_pkg.sv", as well as the registers renamed to SYNC_PERIOD in the axi_tdd simulation? This follows the change on the HDL main: analogdevicesinc/hdl@065c8f1 |
This request is unrelated to the next_main restructuring and I suggest updating this in a separate PR. |
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the changes to update the dma framelock PR.
For reference, these were the steps:
PROJECT=dma_flock
DEST=ip
git mv dma_flock/ testbenches/$DEST
pushd testbenches/$DEST/$PROJECT/
vi Makefile system_project.tcl system_bd.tcl
# Mostly coping other makefile to figure out the new sources paths,
# the patching system_project.tcl to match and finally the sources at system_bd.tcl
# e.g.:
# ../common/sv -> ../../../library/utilities
# see https://github.com/analogdevicesinc/testbenches/pull/104/commits/8da43678b4f5460beabf807fc30d3a513c39e737
Also, executed the i3c_controller tb without issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've ran a few tests (including all using the spi_vip) and everything went fine.
Restructured repository according to the documentation.
Projects have been updated and fixed wherever it was necessary.
CI job was run on the branch, projects are passing/failing the same way as the ones on the current main.