Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next main #124

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Next main #124

merged 10 commits into from
Oct 17, 2024

Conversation

IstvanZsSzekely
Copy link
Contributor

Restructured repository according to the documentation.
Projects have been updated and fixed wherever it was necessary.
CI job was run on the branch, projects are passing/failing the same way as the ones on the current main.

@IstvanZsSzekely IstvanZsSzekely added the update Update current feature label Oct 8, 2024
@IstvanZsSzekely IstvanZsSzekely self-assigned this Oct 8, 2024
StancaPop
StancaPop previously approved these changes Oct 9, 2024
Copy link
Collaborator

@StancaPop StancaPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Built some testbenches, no issues found.

Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Copy link
Contributor

@LBFFilho LBFFilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think library/ips might be better named something else, maybe? It's mostly regmap packages and apis for interacting with the dut ips, so not exactly IPs. Similarly, library/xilinx_vip is sequencers (and I imagine in the future other similar pieces of code) for interacting with testbench VIPs.
So I think they might be renamed something like:

ips -> dut_wrap
xilinx_vips -> tb_wrap

Maybe wrapper is not the ideal term?

library/adi_vip/spi_vip/Makefile Outdated Show resolved Hide resolved
library/ips/spi_engine/s_spi_sequencer.sv Outdated Show resolved Hide resolved
@podgori
Copy link
Contributor

podgori commented Oct 10, 2024

Can you please update the TDDN "adi_regmap_tdd_gen_pkg.sv", as well as the registers renamed to SYNC_PERIOD in the axi_tdd simulation? This follows the change on the HDL main: analogdevicesinc/hdl@065c8f1

@IstvanZsSzekely
Copy link
Contributor Author

Can you please update the TDDN "adi_regmap_tdd_gen_pkg.sv", as well as the registers renamed to SYNC_PERIOD in the axi_tdd simulation? This follows the change on the HDL main: analogdevicesinc/hdl@065c8f1

This request is unrelated to the next_main restructuring and I suggest updating this in a separate PR.

Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the changes to update the dma framelock PR.
For reference, these were the steps:

PROJECT=dma_flock
DEST=ip
git mv dma_flock/ testbenches/$DEST
pushd testbenches/$DEST/$PROJECT/
vi Makefile system_project.tcl system_bd.tcl
# Mostly coping other makefile to figure out the new sources paths,
# the patching system_project.tcl to match and finally the sources at system_bd.tcl
# e.g.:
# ../common/sv -> ../../../library/utilities
# see https://github.com/analogdevicesinc/testbenches/pull/104/commits/8da43678b4f5460beabf807fc30d3a513c39e737

Also, executed the i3c_controller tb without issues.

Copy link
Contributor

@LBFFilho LBFFilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've ran a few tests (including all using the spi_vip) and everything went fine.

@IstvanZsSzekely IstvanZsSzekely merged commit 9770fd6 into main Oct 17, 2024
@IstvanZsSzekely IstvanZsSzekely deleted the next_main branch October 17, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update Update current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants