Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): update marked to latest version and fix custom renderer compatibility #1658

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

kudoas
Copy link
Contributor

@kudoas kudoas commented Mar 20, 2025

PR Checklist

Closes #1420
Closes #1535

What is the new behavior?

Custom renderer now properly handles tokenized inputs introduced in marked v13+, ensuring consistent markdown rendering.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 253e5ad
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/67de413e4a6375000838198e
😎 Deploy Preview https://deploy-preview-1658--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 253e5ad
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/67de413e3d001600081c8204
😎 Deploy Preview https://deploy-preview-1658--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 253e5ad
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/67de413e0d8737000901393c
😎 Deploy Preview https://deploy-preview-1658--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 253e5ad
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/67de413e4966a10008a38ee1
😎 Deploy Preview https://deploy-preview-1658--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kudoas kudoas force-pushed the update-marked-to-v15 branch from e02ac16 to 09f9ee4 Compare March 21, 2025 03:07
@kudoas kudoas marked this pull request as ready for review March 21, 2025 03:30
@kudoas kudoas changed the title Update to marked v15 and fix custom renderer compatibility feat(platform): Update to marked v15 and fix custom renderer compatibility Mar 21, 2025
@kudoas kudoas changed the title feat(platform): Update to marked v15 and fix custom renderer compatibility feat(content): update marked to latest version and fix custom renderer compatibility Mar 21, 2025
@brandonroberts
Copy link
Member

Thanks @kudoas

If we automatically update the package.json with the updated versions, this won't be breaking right?

@kudoas
Copy link
Contributor Author

kudoas commented Mar 24, 2025

@brandonroberts

If we automatically update the package.json with the updated versions, this won't be breaking right?

Thanks for pointing that out — you're right, if package.json is updated automatically, it shouldn't be breaking.
Let me know what changes you think are needed, if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old marked depency marked v14 will break code rendering
2 participants