Fix some bugs #677
Closed
Fix some bugs #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batchflow/batch.py
Outdated
| @@ -634,7 +634,7 @@ def apply_parallel(self, func, init=None, post=None, src=None, dst=None, *args, | |||
| # Compute result. Unbind the method to pass self explicitly | |||
| parallel = inbatch_parallel(init=init, post=post, target=target, src=src, dst=dst) | |||
| transform = parallel(type(self)._apply_once) | |||
| result = transform(self, *args, func=func, p=p, src=src, dst=dst, | |||
| result = transform(self, *args, func=func, p=p, | |||
There was a problem hiding this comment.
Ok. But why do you even need those parameters inside batch actions anyway?
There was a problem hiding this comment.
This way, we can use apply_parallel decorator everywhere, instead of using inbatch_parallel somewhere (like it was previously)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseImageBatchcall withsrc=None(assuming that theixitself is already a full path to image).Undosrcanddstbeing passed byBaseImagesBatch.apply_parallelto batch actions (recent bug, introduced in 4a106c7).