Skip to content

Commit

Permalink
Merge pull request #493 from anchan828/use-onApplicationShutdown
Browse files Browse the repository at this point in the history
fix(#492): use onApplicationShutdown instead of onModuleDestroy
  • Loading branch information
anchan828 authored Nov 23, 2023
2 parents 571d912 + bb6ea3b commit 242441f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,4 @@ typings/
dist
.idea
.DS_Store
.turbo
6 changes: 3 additions & 3 deletions packages/redlock/src/redlock.module.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Inject, Module, OnModuleDestroy } from "@nestjs/common";
import { Inject, Module, OnApplicationShutdown } from "@nestjs/common";
import { RedlockModuleOptions } from "./redlock.interface";
import { ConfigurableModuleClass, MODULE_OPTIONS_TOKEN } from "./redlock.module-definition";
import { RedlockService } from "./redlock.service";
Expand All @@ -13,12 +13,12 @@ import { RedlockService } from "./redlock.service";
],
exports: [RedlockService],
})
export class RedlockModule extends ConfigurableModuleClass implements OnModuleDestroy {
export class RedlockModule extends ConfigurableModuleClass implements OnApplicationShutdown {
constructor(@Inject(MODULE_OPTIONS_TOKEN) private readonly options: RedlockModuleOptions) {
super();
}

public async onModuleDestroy(): Promise<void> {
public async onApplicationShutdown(): Promise<void> {
for (const client of this.options.clients) {
switch (client.status) {
case "end":
Expand Down
6 changes: 3 additions & 3 deletions packages/simple-redlock/src/redlock.module.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Inject, Module, OnModuleDestroy } from "@nestjs/common";
import { Inject, Module, OnApplicationShutdown } from "@nestjs/common";
import { SimpleRedlockModuleOptions } from "./redlock.interface";
import { ConfigurableModuleClass, MODULE_OPTIONS_TOKEN } from "./redlock.module-definition";
import { SimpleRedlockService } from "./redlock.service";
Expand All @@ -13,12 +13,12 @@ import { SimpleRedlockService } from "./redlock.service";
],
exports: [SimpleRedlockService],
})
export class SimpleRedlockModule extends ConfigurableModuleClass implements OnModuleDestroy {
export class SimpleRedlockModule extends ConfigurableModuleClass implements OnApplicationShutdown {
constructor(@Inject(MODULE_OPTIONS_TOKEN) private readonly options: SimpleRedlockModuleOptions) {
super();
}

public async onModuleDestroy(): Promise<void> {
public async onApplicationShutdown(): Promise<void> {
switch (this.options.client.status) {
case "end":
break;
Expand Down

0 comments on commit 242441f

Please sign in to comment.