group/exitinof: replace spin_lock to critical_section avoid deadlock

holding the irqsaved spinlock first and then take critical section may cause deadlock in SMP case replace spin_lock to critical_section avoid deadlock Signed-off-by: chao an <[email protected]>
anchao · Oct 13, 2024 · 1ff49f0 · 1ff49f0
1 parent c37b0de
commit 1ff49f0
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/sched/group/group_exitinfo.c b/sched/group/group_exitinfo.c
@@ -31,7 +31,6 @@
 #include <errno.h>
 
 #include <nuttx/sched.h>
-#include <nuttx/spinlock.h>
 #include <nuttx/binfmt/binfmt.h>
 
 #include "sched/sched.h"
@@ -70,14 +69,14 @@ int group_exitinfo(pid_t pid, FAR struct binary_s *bininfo)
   irqstate_t flags;
 
   DEBUGASSERT(bininfo != NULL);
-  flags = spin_lock_irqsave(NULL);
+  flags = enter_critical_section();
 
   /* Get the TCB associated with the PID */
 
   tcb = nxsched_get_tcb(pid);
   if (tcb == NULL)
     {
-      spin_unlock_irqrestore(NULL, flags);
+      leave_critical_section(flags);
       return -ESRCH;
     }
 
@@ -90,7 +89,7 @@ int group_exitinfo(pid_t pid, FAR struct binary_s *bininfo)
 
   group->tg_bininfo = bininfo;
 
-  spin_unlock_irqrestore(NULL, flags);
+  leave_critical_section(flags);
   return OK;
 }