Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discover deb file relationships in distroless images #1901

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

westonsteimel
Copy link
Contributor

For distroless images the md5sum files are under /var/lib/dpkg/status.d/ rather than /var/lib/dpkg/info/

Fixes #1900

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz%0A                                                          │ ./.tmp/benchmark-e64ac6e.txt │%0A                                                          │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   14.94m ±  4%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    902.5µ ±  3%25%0AImagePackageCatalogers/binary-cataloger-2                                   250.9µ ±  2%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   735.2µ ±  3%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              1.525m ±  3%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         113.1µ ±  1%25%0AImagePackageCatalogers/java-cataloger-2                                     16.67m ±  3%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     112.0µ ±  1%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       516.0µ ± 17%25%0AImagePackageCatalogers/nix-store-cataloger-2                                340.5µ ±  3%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   970.2µ ±  1%25%0AImagePackageCatalogers/portage-cataloger-2                                  587.9µ ±  1%25%0AImagePackageCatalogers/python-package-cataloger-2                           4.108m ±  2%25%0AImagePackageCatalogers/r-package-cataloger-2                                260.0µ ±  3%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   648.9µ ±  2%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             1.127m ±  1%25%0AImagePackageCatalogers/sbom-cataloger-2                                     146.7µ ±  3%25%0Ageomean                                                                     758.9µ%0A%0A                                                          │ ./.tmp/benchmark-e64ac6e.txt │%0A                                                          │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                   5.123Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                    205.1Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                   30.19Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                   168.9Ki ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                              405.4Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                         9.906Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                     2.827Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                     8.594Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                       100.9Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                49.14Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                   186.8Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                  119.9Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                           1.003Mi ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                53.30Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                   180.9Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                             144.0Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                     14.20Ki ± 0%25%0Ageomean                                                                     132.7Ki%0A%0A                                                          │ ./.tmp/benchmark-e64ac6e.txt │%0A                                                          │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                    87.75k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                     4.182k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                     830.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                    3.002k ± 0%25%0AImagePackageCatalogers/dotnet-deps-cataloger-2                               6.338k ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                           281.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                      39.89k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                       228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                        1.404k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                  895.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                    4.079k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                   2.269k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                            16.44k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                  929.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                    3.989k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                              2.447k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                       394.0 ± 0%25%0Ageomean                                                                      2.583k

@westonsteimel westonsteimel force-pushed the collect-package-ownership-data-distroless branch from 3b582fe to 93a87be Compare June 28, 2023 09:51
@westonsteimel westonsteimel requested a review from a team June 28, 2023 09:51
@westonsteimel westonsteimel force-pushed the collect-package-ownership-data-distroless branch from 93a87be to afb62e8 Compare June 28, 2023 10:11
@westonsteimel westonsteimel merged commit 8219f8d into main Jun 28, 2023
@westonsteimel westonsteimel deleted the collect-package-ownership-data-distroless branch June 28, 2023 12:28
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distroless image incorrectly reporting DEB python as binary
2 participants