-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new Java configuration option to recursively search parent poms… #2274
Conversation
6f32ee0
to
cbddc73
Compare
… for licenses Signed-off-by: Colm O hEigeartaigh <[email protected]>
cbddc73
to
c4c6a83
Compare
Thanks for the update @coheigea! I'm going to add a unit test here exercising the online behavior with a |
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
I'm going to make a small change to this PR - we're going to remove the more specific
In favor of a master top level switch
|
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- nothing blocking, but a few suggestions
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
After getting some feedback about adding the top level option of It's unclear to me of the primacy of the options in this case: Below is the breaking change where users would need to flip the switch on to preserve golang option:
|
Thanks a lot @spiffcs for whipping my PRs into shape :-) |
Signed-off-by: Christopher Phillips <[email protected]>
After more thought, We've decided that adding |
Signed-off-by: Christopher Phillips <[email protected]>
anchore#2274) - Add a new Java configuration option to recursively search parent poms for licenses --------- Signed-off-by: Colm O hEigeartaigh <[email protected]> Signed-off-by: Christopher Phillips <[email protected]> Co-authored-by: Christopher Phillips <[email protected]>
… for licenses
Part 2 of #2103
#2228 added the ability to read a license from a parent pom in a remote repository like Maven Central. However that PR did not find the license when the license was embedded in a parent pom greater than one level up.
This PR introduces a new Java config option "max-parent-recursive-depth" which defaults to 5. When "search-maven-for-licenses" is enabled, it will recursively go through the parent poms up to "max-parent-recursive-depth" to find a license.
With this PR Syft can now successfully find licenses for: