Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support detection of Chrome binaries #3136

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lem-onade
Copy link

@lem-onade lem-onade commented Aug 19, 2024

Finds results for chrome binaries, tested with v126 linux64 and v127 linux64 binaries inside a local dir

image

tested with ppodgorsek/robot-framework, installs chrome binary using npx @puppeteer/browsers install chrome@VERSION in Dockerfile

image

tested with browserless/chrome (chrome 121) -- detects binary

image

Signed-off-by: Stijn Taelemans <[email protected]>
Signed-off-by: Stijn Taelemans <[email protected]>
@lem-onade lem-onade force-pushed the feat/support-chrome-binary-version-detection branch from d238549 to 880f5db Compare August 19, 2024 11:05
@lem-onade lem-onade marked this pull request as ready for review August 19, 2024 11:39
@lem-onade lem-onade marked this pull request as draft August 28, 2024 09:20
@SemProvoost
Copy link
Contributor

@kzantow, any chance you could review/merge this when you have a moment? Thanks! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants