feat: --enrich flag for data enrichment feature enablement #3182
+217
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logers Signed-off-by: Keith Zantow <[email protected]>
wagoodman
reviewed
Sep 3, 2024
wagoodman
previously approved these changes
Sep 3, 2024
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
|
A few questions came up during discussions, so I'm not going to merge this as-is; will get some feedback first |
kzantow
dismissed
wagoodman’s stale review
There are probably going to be changes after discussion
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
changed the title
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
kzantow
commented
Sep 9, 2024
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
approved these changes
Sep 9, 2024
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
wagoodman
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an
--enrichflag, to allow Syft to enable data enrichment operations for all catalogers with a single flag. These operations often involve network requests to services like Maven Central, NPM, or GitHub. In the future there are likely to be an increasing number of remote network services that Syft is able to utilize, and this would be the first step to enabling that easily and automatically opting-in to future enrichment operations for all users who want the best quality SBOM they can get.The easiest way to enable everything, is to use
--enrich all, and Syft will enable all enrichment operations, which currently include Golang local and remote searches, Maven local and remote searches, and NPM lookups. This PR also supports enabling and disabling individual cataloger data data enhancement if there are any reasons to do so.