Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update tools to latest versions #3205

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

anchore-actions-token-generator[bot]
Copy link
Contributor

@anchore-actions-token-generator anchore-actions-token-generator bot commented Sep 8, 2024

 TOOL           UPDATE            
──────────────────────────────────
 gh             v2.55.0 → v2.56.0 
 golangci-lint  v1.60.3 → v1.61.0 
 goreleaser     v2.2.0 → v2.3.0

This is an auto-generated pull request to update all of the tools to the latest versions.

@anchore-actions-token-generator anchore-actions-token-generator bot added the dependencies Involves changes to go.mod go.sum label Sep 8, 2024
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
A change to the rule gosec(G115) made a large amount of FP for gosec appear when updating to the
latest golang-ci linter.

securego/gosec#1185
securego/gosec#1149

We're going to ignore this rule for the time being while waiting for gosec to get updates so that
bound checking and example snippets of `valid` code is added for this rule

Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
Copy link
Contributor

spiffcs commented Sep 13, 2024

chore: disable gosec(G115)

A change to the rule gosec(G115) made a large amount of FP for gosec appear when updating to the
latest golang-ci linter.

securego/gosec#1185
securego/gosec#1149

We're going to ignore this rule for the time being while waiting for gosec to get updates so that
bound checking and example snippets of valid code are added for this rule

We will reenable when the rule is a bit more stable and it's clear the changes we need.

As a result of disabling this rule the linter would fail saying we had unused ignores. Those have been removed for the time being.

Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also seems related to securego/gosec#1212

@spiffcs spiffcs merged commit 58100fe into main Sep 13, 2024
12 checks passed
@spiffcs spiffcs deleted the auto/latest-tools branch September 13, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Involves changes to go.mod go.sum
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants