fix: handle more ubuntu git repo errors #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonsteimel
added
the
run-pr-quality-gate
Currently there may be situations where there are untracked files present in the ubuntu git working directory (likely due to some previous failure state), so the provider will now automatically issue a `git clean -fd` to try and resolve these rather than failing. If the pull still fails, then just re-clone the repo (except in the case of 503 errors) Now raises a specific exception for the 503 errors which are frequently issued by the upstream https endpoint so that specific scenario can be handled separately Signed-off-by: Weston Steimel <[email protected]>
westonsteimel
force-pushed
the
ubuntu-git-error-handling
branch
from
e5b1b26
to
b306356
Compare
kzantow
approved these changes
Jun 27, 2023
| except Exception as e: | ||
| self.logger.exception("error executing command: {}".format(cmd)) | ||
|
|
||
| if isinstance(e, subprocess.CalledProcessError): | ||
| if e.stderr and self._ubuntu_server_503_message in e.stderr.decode(): |
westonsteimel
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there could be situations where there are untracked files present in the ubuntu git working directory (likely due to some previous failure state), so the provider will now automatically issue a
git clean -fdto try and resolve these rather than failing. If the pull still fails, then just re-clone the repo (except in the case of 503 errors)Now raises a specific exception for the 503 errors which are frequently issued by the upstream https endpoint so that specific scenario can be handled separately