Gateways : Visualiser la liste des membres de ma gouvernance #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ornella452
force-pushed
the
gererLesMembres_partie_gateways
branch
from
e37d38a to
6796bed
Compare
NerOcrO
reviewed
Jan 30, 2025
Comment on lines
+18
to
+19
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion | ||
| const result = (await this.#dataResourceGouvernance.$queryRaw` |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion | |
| const result = (await this.#dataResourceGouvernance.$queryRaw` | |
| const result: ReadonlyArray<Membres> = await this.#dataResourceGouvernance.$queryRaw` |
Par défaut, les as sont en dernier recours
| role: ReadonlyArray<string> | ||
| } | ||
| export class PrismaMesMembresLoader extends MesMembresLoader { | ||
| readonly #dataResourceGouvernance: PrismaClient |
There was a problem hiding this comment.
Suggested change
| readonly #dataResourceGouvernance: PrismaClient | |
| readonly #dataResource PrismaClient |
Pour être consistent avec les autres loaders
Comment on lines
+5
to
+8
| interface Membres { | ||
| nomMembre: string | ||
| role: ReadonlyArray<string> | ||
| } |
There was a problem hiding this comment.
Suggested change
| interface Membres { | |
| nomMembre: string | |
| role: ReadonlyArray<string> | |
| } | |
| type Membres = Readonly<{ | |
| nomMembre: string | |
| role: ReadonlyArray<string> | |
| }> |
Une interface est faite pour être intanciée, hors, ce n'est pas le cas ici.
Et met le tout en bas du fichier car c'est moins important que la classe
| UNION ALL | ||
| SELECT structure AS "nomMembre", ARRAY_AGG(role) AS role FROM membre_gouvernance_structure WHERE "gouvernanceDepartementCode" = ${codeDepartementGouvernance} GROUP BY structure | ||
| UNION ALL | ||
| SELECT departement.nom AS "nomMembre", ARRAY_AGG(membre_gouvernance_departement.role) AS role FROM membre_gouvernance_departement INNER JOIN departement ON membre_gouvernance_departement."departementCode" = departement.code |
There was a problem hiding this comment.
Suggested change
| SELECT departement.nom AS "nomMembre", ARRAY_AGG(membre_gouvernance_departement.role) AS role FROM membre_gouvernance_departement INNER JOIN departement ON membre_gouvernance_departement."departementCode" = departement.code | |
| SELECT departement.nom AS "nomMembre", ARRAY_AGG(membre_gouvernance_departement.role) AS role FROM membre_gouvernance_departement INNER JOIN departement ON membre_gouvernance_departement."departementCode" = departement.code |
| }, | ||
| ].map((membre) => ({ | ||
| ...membre, | ||
| roles: (result.find((membreDb: Membres) => membreDb.nomMembre === membre.nom)?.role ?? []) as ReadonlyArray<Role>, |
There was a problem hiding this comment.
Suggested change
| roles: (result.find((membreDb: Membres) => membreDb.nomMembre === membre.nom)?.role ?? []) as ReadonlyArray<Role>, | |
| roles: (result.find((membreDb: Membres) => membreDb.nomMembre === membre.nom)?.role ?? []) as MesMembresReadModel['roles'], |
Comme tu peux éviter d'exporter Role
| }) | ||
| } | ||
|
|
||
| async function ajoutMembreGouvernanceCommune(): Promise<void> { |
There was a problem hiding this comment.
C'est pas mal ça, vu que l'on fait souvent ça et de manière répétitive, on pourrait les mettre dans le testHelper et les utiliser tout le temps !
| }) | ||
| }) | ||
|
|
||
| async function preRequisGouvernanceRhone(): Promise<void> { |
There was a problem hiding this comment.
Ca serait plus auto portant de la découper en 3 pour mieux voir dans le GIVEN le scénario
| @@ -0,0 +1,189 @@ | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrat du dev
Qualité
Facultatif mais fortement conseillé