Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precomputed RGB565 Color palette #69

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Precomputed RGB565 Color palette #69

merged 4 commits into from
Mar 27, 2024

Conversation

frostmorn
Copy link
Collaborator

@frostmorn frostmorn commented Mar 27, 2024 •
edited
Loading

closes #37

@and3rson
Copy link
Owner

@frostmorn Хороша ідея! Але, оскільки кольори вже і так в окремому неймспейсі, може краще забрати префікс RGB565_?

@frostmorn
Copy link
Collaborator Author

чудова думка!

@and3rson
Copy link
Owner

and3rson commented Mar 27, 2024 •
edited
Loading

@frostmorn І ще - треба додати typedef перед enum, щоб воно норм підтягувалось в doxygen:

typedef enum {
    // ...
} RGB_565_Colors;

зображення

І ще, це усуває один warning від clang.

@frostmorn
Copy link
Collaborator Author

Done :)

@and3rson
Copy link
Owner

Супер!

@and3rson and3rson self-requested a review March 27, 2024 15:50
@and3rson and3rson merged commit 39d2505 into main Mar 27, 2024
3 checks passed
@and3rson and3rson deleted the precomputed_color_palette branch March 27, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@and3rson and3rson and3rson approved these changes

Assignees
No one assigned
Labels
scope:sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add color pallete with predefined values for RGB565 Colors
2 participants
@frostmorn @and3rson