Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (YT) : Overlay Button that opens up Android's Native Share Menu. #50

Closed
4 tasks done
Aryan-Chauhan opened this issue Mar 15, 2024 · 7 comments
Closed
4 tasks done

Comments

@Aryan-Chauhan
Copy link

Application

YouTube

Feature description

Please add an overlay button that, when clicked, opens up Android's Native Share Menu.
Screenshot_2024-03-15-07-46-07-16_c31b32364ce19ca8fcd150a417ecce58

Motivation

• Android's Native Share Menu has equal importance to that of Playback Speed Menu, but only the latter has a dedicated overlay button (as of yet).

• It will save steps/taps for opening Android's Native Share Menu. Saving steps/taps was also the motivation behind Playback Speed Overlay Button, so Android's Native Share Menu should also get equal treatment.
1710472210920

• If implemented, large number of people will use it, just like they use Playback Speed Overlay Button.

• I've personally seen multiple positive comments on how convenient Playback Speed Overlay Button is, and the proposed button is also a convenient & practical one. So, that's why it should be implemented.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@YT-Advanced
Copy link
Contributor

I think add a patch to force open native share menu is better

@Aryan-Chauhan
Copy link
Author

I think add a patch to force open native share menu is better

I don't use Button Containers because they are cosmetically buggy (they have inconsistent padding/spacing):

ReVanced/revanced-patches#62

inotia00/ReVanced_Extended#17

inotia00/ReVanced_Extended#89

inotia00/ReVanced_Extended#451

inotia00/ReVanced_Extended#674

inotia00/ReVanced_Extended#1754

I use my app like this:
Screenshot_2024-03-17-08-43-18-88_f22faf49515899f9781ec174a4d85388.jpg

@anddea
Copy link
Owner

anddea commented Mar 17, 2024

This padding between the buttons is caused by the way the litho filter hides the elements, in the case of this "button container" it hides only the button, but there are 2 parent elements of this button that have this padding. Solution: either rewrite the button filtering in a different way, or add some kind of a parental deletion to litho, which will cause problems with other elements. Because the litho filter hides a lot of things: ads, buttons, custom, new keyword filter, etc, and all of that works fine except for the button container.

@Aryan-Chauhan
Copy link
Author

This padding between the buttons is caused by the way the litho filter hides the elements, in the case of this "button container" it hides only the button, but there are 2 parent elements of this button that have this padding. Solution: either rewrite the button filtering in a different way, or add some kind of a parental deletion to litho, which will cause problems with other elements. Because the litho filter hides a lot of things: ads, buttons, custom, new keyword filter, etc, and all of that works fine except for the button container.

Yes, that's why I requested for a Share Overlay Button instead of "Hook Share Button" that Alireza was talking about.

I always want to keep Button Containers hidden.

@Aryan-Chauhan
Copy link
Author

Not exactly, but kinda similar:

ReVanced/revanced-patches#1896

@Aryan-Chauhan
Copy link
Author

Closing this issue, because I listed all my YT feature requests in this single issue:

#225

@Aryan-Chauhan Aryan-Chauhan reopened this May 16, 2024
anddea added a commit that referenced this issue May 31, 2024
…` and more `Start page` options (#50)

* feat(YouTube): Add `Hide live chat messages`

* feat(YouTube/Overlay buttons): Add ability to reset speed back to default on second tap and hold

* feat(YouTube/Overlay buttons): Add `Time-ordered playlist` from channel videos

* feat(YouTube/Overlay buttons): Add more icon types and selectable bottom margin

* feat(YouTube): Add more start page options

* refactor: remove period from speed reset toast

* feat(YouTube): Add `Hide live chat replay`

* feat(YouTube/Swipe controls): Add adjustable `Swipe overlay screen size`

* fix(YouTube/Swipe controls): Normalize default text size

* chore: clarify swipe overlay screen size description

* chore: remove whitelist icons

---------

Co-authored-by: inotia00 <[email protected]>
@anddea anddea closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2024
@Francesco146
Copy link
Collaborator

this one is doable, I'll write them down for when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants