Merged pull request... #14
Conversation
get_fields() is new in django 1.8 get_all_field_names() was removed in django 1.10
* Split published/visible in QuerySet and Manager * Made drafts/publish/visible available in QuerySet and Manager * bind manager to "objects" instead of "publisher_manager" * Update/expand tests See also: https://github.com/andersinno/django-model-publisher- ai/pull/9#discussion_r136539316
tests/myapp/models.py
Outdated
| try: | ||
| import parler | ||
| except ImportError: | ||
| PARLER_INSTALLED=False |
There was a problem hiding this comment.
Just set parler = None and use if parler: to check if it's available.
tests/myapp/models.py
Outdated
| try: | ||
| import aldryn_translation_tools | ||
| except ImportError as err: | ||
| TRANSLATION_TOOLS_INSTALLED=False |
There was a problem hiding this comment.
same here, use aldryn_translation_tools = None for the except part. Also, remove the as err.
|
Anything else that needs to be changed to merged? |
|
Sorry, but this PR is too big. My time for this project is quite limited and reviewing all these unrelated changes in a single PR needs bigger "timeslot" than I have available for a while for this. The start_date/end_date thing started to look ready for merging before you combined it here, so maybe just revive it in the separate PR? |
|
That's a dilemma. My time is also limited. That's why I merged the changes. And there's also another new thing coming up: I need a role "request publishing" and "accept/reject publish request" with short message exchange. All this is too time-consuming to implement completely separately. Maybe i should made my fork independent and publish a new package to PyPi?!? |
|
@jedie I think there is value in focusing development into one repo. So if you want, we can still try to help you out in ironing the features. Just that, the smaller and more concise the PR, the easier it is to review and iterate on. |
I agree with you. But the reactions times are very long or there is no response. e.g.: #11 -> a simple bugfix + editorconfig, 8 days old -> No reaction Or the hint at #5 ... no reaction... I think the interest in this project is very low. |
|
@jedie You are right, this is not actively maintained project, rather a occasionally maintained fork from an abandoned project. So indeed, it might make sense to have your own fork to keep things going forward in your projects. |
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage ? 50.99%
=========================================
Files ? 11
Lines ? 553
Branches ? 74
=========================================
Hits ? 282
Misses ? 262
Partials ? 9
Continue to review full report at Codecov.
|
|
I have made a fork, merge all my changes and release this on PyPi as django-ya-model-publisher: github: https://github.com/wearehoods/django-ya-model-publisher/ |
It is time-consuming to maintain all changes in separate pull requests.
So i merged all changes from #9 #10 #11 and #13