Supporting multiple brokers #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazeemkhan77
reviewed
Apr 4, 2018
| ticker := time.NewTicker(check.config.retryInterval) | ||
| defer ticker.Stop() | ||
| for { | ||
| select { | ||
| case <-ticker.C: | ||
| if err := check.tryConnectOnce(&createHealthTopicIfMissing, &createReplicationTopicIfMissing); err == nil { | ||
| return nil | ||
| }else{ |
There was a problem hiding this comment.
Thanks for making the changes to support multiple brokers. I found a major issue and I need your help to resolve it. If one of the brokers is down during the initialization, the service gets into an infinite loop to connect to the unavailable broker and the cluster response is overridden with {"status": "red"}. That gives a false impression that the overall cluster is down, whereas other brokers are up and running. If all brokers are up and running, then it gives the complete result.
nilaysahu
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case , kafka-health-check is being run on a single machine and it needs to do health check on multiple brokers. This fork takes multiple broker ips separated comma and loops to do a health check on all of them.