Fix race cond. when expanding replication topic #34
+143
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make test complains with: > check/health_check.go:115: Warn call has possible formatting directive %s
Two or more health check instances started at around the same time would read the partition assignment state, selfishly add only themselves, and the last to write would be the result. The loser health check instance would get into an endless loop of: "Unable to find broker's partition in topic \"broker-replication-check\" in metadata"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two or more health check instances started at around the same time would
read the partition assignment state, selfishly add only themselves, and
the last to write would be the result. The loser health check instance
would get into an endless loop of: