Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI, python, and cmake cleanup #47

Merged
merged 17 commits into from
Sep 10, 2024
Merged

Conversation

sarnold
Copy link

@sarnold sarnold commented Sep 7, 2024

I started this earlier in the year but then I got busy and had to add more fixes on top of fixes, but it's clean again. So

  • improved cmake bits - updated pybind11 and findPython/Cython, set c++17 with extensions, enable new policy
  • cleaned up CI workflows - platform wheels get newer quay image and pegged macos target version
  • some test cleanup for python updates (new warnings in Py 3.12 still there)
  • update setup.py and migrate to setuptools_scm

This does address C++ std warnings in issue #46 as well as #48, #44, #43, and stale/other version issues. You should probably validate the fix for #48 just to make sure

sarnold and others added 11 commits September 7, 2024 10:04
* update pybind11 usage and set cmake python vars to Title_CASE
* refactor cmake extension build to use pybind11 module bits
* move emptygroups test from "differences"

Signed-off-by: Steve Arnold <[email protected]>
* cleanup asserts and add groups() test

Signed-off-by: Steve Arnold <[email protected]>
* refactor setup.py after pybind11 upstream changes

Signed-off-by: Steve Arnold <[email protected]>
* cleanup ci workflow, remove crufty makefile with deprecated
  setup.py commands
* remove the package_dir bit from setup.py

Signed-off-by: Steve Arnold <[email protected]>
* check if find_package py3 works across all CI runners

Signed-off-by: Steve Arnold <[email protected]>
* no epel pkgs for linux aarch64, enable PYBIND11_FINDPYTHON
* set macos deployment target to 10.9

Signed-off-by: Steve Arnold <[email protected]>
* revert to macos-13 with the same version as target
* In Theory this should get us full c++17

Signed-off-by: Stephen Arnold <[email protected]>
@sarnold sarnold mentioned this pull request Sep 7, 2024
@sarnold sarnold force-pushed the py-cleanup branch 5 times, most recently from 771cf2c to 5696f8a Compare September 8, 2024 01:09
* split all runners into separate arch via matrix
* macos does need macos-14 to get a proper arm64 build

Signed-off-by: Stephen Arnold <[email protected]>
@sarnold sarnold force-pushed the py-cleanup branch 4 times, most recently from 567729c to e69afb2 Compare September 8, 2024 05:53
@sarnold
Copy link
Author

sarnold commented Sep 8, 2024

So this is telling us there is still some Py2 cruft somewhere, possibly just a n import, or else it would not be looking for 'six'.

* this is essentially a workaround for non-pypi pkg cruft

Signed-off-by: Stephen Arnold <[email protected]>
@sarnold sarnold force-pushed the py-cleanup branch 2 times, most recently from 6ab899d to 59d742f Compare September 9, 2024 00:25
* also cleanup the wheel artifact check, download to artifacts/

Signed-off-by: Stephen Arnold <[email protected]>
@andreasvc andreasvc merged commit 00ff29d into andreasvc:master Sep 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants