Add grouped_notifications API #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PattaFeuFeu
added
documentation
PattaFeuFeu
force-pushed
the
mastodon-4.3/addition/notification_group_key
branch
from
a6c9891
to
ae9f837
Compare
PattaFeuFeu
changed the title
PattaFeuFeu
force-pushed
the
mastodon-4.3/addition/notification_group_key
branch
from
91e89a5
to
14fb2a2
Compare
PattaFeuFeu
force-pushed
the
mastodon-4.3/addition/notification_group_key
branch
2 times, most recently
from
cfd0518
to
295df83
Compare
PattaFeuFeu
force-pushed
the
mastodon-4.3/addition/notification_group_key
branch
from
295df83
to
473f8c8
Compare
Breaking in case library consumers relied on Enum’s ordinal as new options were added in-between to keep alphabetical order.
Circumvents odd case where api/v2/notifications, despite supporting pagination, returns just a JSONObject and not a JSONArray See mastodon/mastodon#32594
PattaFeuFeu
force-pushed
the
mastodon-4.3/addition/notification_group_key
branch
from
473f8c8
to
8d03a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds new methods for Grouped Notifications that were added as part of the most recent Mastodon 4.3.0 release.
Sorry, this got a lot larger than initially intended. When starting to add methods, I had to add some new properties and entities as well.
During implementation, I noticed one odd server return that I raised as a bug ticket as the return doesn’t feel right to me. To circumvent the current behaviour, I have added ed72848 as otherwise, our current approach to pageable data doesn’t allow for the structure returned.
Type of Change
Breaking Changes
Notification.NotificationTypewas moved to its own class. Import changes fromimport social.bigbone.api.entity.Notification.NotificationTypetoimport social.bigbone.api.entity.NotificationTypeNotificationTypes were added and they are still in alphabetical order. So if you relied onNotificationType#ordinal, please be aware that ordinals changed.How Has This Been Tested?
Mandatory Checklist
gradle checkand there were no errors reportedOptional checks
*Methodsclasses: Did you also reference it in theMastodonClientmain class?/docsfolder (e.g. API Coverage page)?