Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1.16.5 support #962

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

ImYenil
Copy link
Contributor

@ImYenil ImYenil commented Jan 24, 2024

Fixed bug where version 1.16.5 was not supported

Available only after accepting this andrei1058/SidebarLib#48 pull request

andrei1058 and others added 3 commits December 10, 2023 16:13
Fixed bug where version 1.16.5 was not supported
Fixed bug where version 1.16.5 was not supported
@andrei1058 andrei1058 changed the base branch from master to develop February 3, 2024 16:17
<artifactId>sidebar-v1_16_R1</artifactId>
<version>23.12</version>
<artifactId>sidebar-v1_16_R3</artifactId>
<version>23.12.1-SNAPSHOT</version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove snapshot from here please

Copy link
Owner

@andrei1058 andrei1058 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know when you removed the snapshot from the version string

@andrei1058 andrei1058 added the requires-changes Pull requests which need to be updated based on review comments and then reviewed again. label Feb 3, 2024
@andrei1058
Copy link
Owner

andrei1058 commented Feb 3, 2024

New version for sidebar lib: 24.2

removed the snapshot from the version string
@ImYenil
Copy link
Contributor Author

ImYenil commented Feb 7, 2024

let me know when you removed the snapshot from the version string

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-changes Pull requests which need to be updated based on review comments and then reviewed again.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants