[Feature / WIP] Add frame option for collage #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andi34
reviewed
Jun 4, 2020
| @@ -122,6 +122,8 @@ const L10N = { | |||
| 'polaroid_effect': 'Polaroid Effekt', | |||
| 'general_polaroid_rotation': 'Polaroid Bild-Rotation', | |||
| 'use_collage': 'Foto-Collage erlauben', | |||
| 'take_collage_frame': 'Foto-Collage mit Rahmen aufnehmen', | |||
| 'take_collage_frame_path': 'Rahmen', | |||
There was a problem hiding this comment.
general_take_collage_frame_path
andi34
requested changes
Jul 23, 2020
| @@ -122,6 +122,8 @@ const L10N = { | |||
| 'polaroid_effect': 'Polaroid effect', | |||
| 'general_polaroid_rotation': 'Polaroid picture rotation', | |||
| 'use_collage': 'Allow photo collage', | |||
| 'take_collage_frame': 'Take collage with frame', | |||
| 'take_collage_frame_path': 'Frame', | |||
| 'take_frame': 'Take picture with frame', | |||
There was a problem hiding this comment.
general_take_collage_frame_path here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following use case:
I used a specific frame for single photos (text + funny picture of bridal couple), but it's simply too much on a collage.
Feature:
This RP implements the option to set the frame option on single picture and collages separately, as well the option to use different frames for single picture and collages.
Need help with: