Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I506 #2

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

I506 #2

wants to merge 46 commits into from

Commits on Apr 6, 2024

  1. typo fix

    Avinesh authored and stephenfin committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    2aa4742 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. trivial: Prepare for ruff bump

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    0f50a62 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. pre-commit: Bump versions

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ffbd322 View commit details
    Browse the repository at this point in the history
  2. docker: Make .env file optional

    I now have a standard UID and GID of 1000, making this file unnecessary.
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    3e5bb7e View commit details
    Browse the repository at this point in the history
  3. requirements: Bump various libraries

    djangorestframework, django-filter, django-debug-toolbar, sqlparse,
    python-dateutil and openapi-core all have updates.
    
    The only change here is, yet again, openapi-core related, as we swap out
    a deprecated API with its replacement.
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    47add6b View commit details
    Browse the repository at this point in the history
  4. Remove unused import

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b648ba0 View commit details
    Browse the repository at this point in the history
  5. build(deps): update psycopg2 requirement from ~=2.9.0 to ~=2.9.9

    Updates the requirements on [psycopg2](https://github.com/psycopg/psycopg2) to permit the latest version.
    - [Changelog](https://github.com/psycopg/psycopg2/blob/master/NEWS)
    - [Commits](psycopg/psycopg2@2.9.6...2.9.9)
    
    ---
    updated-dependencies:
    - dependency-name: psycopg2
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and stephenfin committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    33b209d View commit details
    Browse the repository at this point in the history
  6. build(deps): update django requirement from ~=5.0.0 to ~=5.0.7

    Updates the requirements on [django](https://github.com/django/django) to permit the latest version.
    - [Commits](django/django@5.0...5.0.7)
    
    ---
    updated-dependencies:
    - dependency-name: django
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and stephenfin committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1921a9b View commit details
    Browse the repository at this point in the history
  7. build(deps): update psycopg2-binary requirement from ~=2.9.0 to ~=2.9.9

    Updates the requirements on [psycopg2-binary](https://github.com/psycopg/psycopg2) to permit the latest version.
    - [Changelog](https://github.com/psycopg/psycopg2/blob/master/NEWS)
    - [Commits](psycopg/psycopg2@2.9.6...2.9.9)
    
    ---
    updated-dependencies:
    - dependency-name: psycopg2-binary
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and stephenfin committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e879cda View commit details
    Browse the repository at this point in the history
  8. pre-commit: Everything in Python 3 now

    No need to set the default Python version.
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4ec9033 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. build(deps): update openapi-core requirement from ~=0.19.0 to ~=0.19.2

    Updates the requirements on [openapi-core](https://github.com/python-openapi/openapi-core) to permit the latest version.
    - [Release notes](https://github.com/python-openapi/openapi-core/releases)
    - [Commits](python-openapi/openapi-core@0.19.0...0.19.2)
    
    ---
    updated-dependencies:
    - dependency-name: openapi-core
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and stephenfin committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c6fa6e7 View commit details
    Browse the repository at this point in the history
  2. build(deps): update mysqlclient requirement from ~=2.2.0 to ~=2.2.4

    Updates the requirements on [mysqlclient](https://github.com/PyMySQL/mysqlclient) to permit the latest version.
    - [Release notes](https://github.com/PyMySQL/mysqlclient/releases)
    - [Changelog](https://github.com/PyMySQL/mysqlclient/blob/main/HISTORY.rst)
    - [Commits](PyMySQL/mysqlclient@v2.2.0...v2.2.4)
    
    ---
    updated-dependencies:
    - dependency-name: mysqlclient
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and stephenfin committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    955e80c View commit details
    Browse the repository at this point in the history
  3. build(deps-dev): update django-debug-toolbar requirement

    Updates the requirements on [django-debug-toolbar](https://github.com/jazzband/django-debug-toolbar) to permit the latest version.
    - [Release notes](https://github.com/jazzband/django-debug-toolbar/releases)
    - [Changelog](https://github.com/jazzband/django-debug-toolbar/blob/main/docs/changes.rst)
    - [Commits](django-commons/django-debug-toolbar@4.4...4.4.6)
    
    ---
    updated-dependencies:
    - dependency-name: django-debug-toolbar
      dependency-type: direct:development
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and stephenfin committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    77b2060 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. build(deps): update sqlparse requirement from ~=0.5.0 to ~=0.5.1

    Updates the requirements on [sqlparse](https://github.com/andialbrecht/sqlparse) to permit the latest version.
    - [Changelog](https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG)
    - [Commits](andialbrecht/sqlparse@0.5.0...0.5.1)
    
    ---
    updated-dependencies:
    - dependency-name: sqlparse
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and stephenfin committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4dfe699 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. CI: docker-compose -> docker compose

    Per [1].
    
    [1] https://github.com/orgs/community/discussions/116610
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    af477a9 View commit details
    Browse the repository at this point in the history
  2. pre-commit: Bump versions

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    009dc90 View commit details
    Browse the repository at this point in the history
  3. Drop Python 3.8 support

    We also add a release note for Python 3.12 support.
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    18e91c4 View commit details
    Browse the repository at this point in the history
  4. requirements: Bump Django to 5.1.x, django-filter to 24.3.0

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5e2f3b8 View commit details
    Browse the repository at this point in the history
  5. Add Python 3.13 support

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    80d5962 View commit details
    Browse the repository at this point in the history
  6. requirements: Bump versions

    We also add a release note for the Django version bump. We should have
    done both in commit 5e2f3b8.
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8242e9d View commit details
    Browse the repository at this point in the history
  7. docker-compose: Remove version

    This is obsolete, apparently.
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9d2eaff View commit details
    Browse the repository at this point in the history
  8. dependabot: Ignore (most) patch update

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bbcefad View commit details
    Browse the repository at this point in the history
  9. dependabot: Manage GitHub Action workflows also

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b8856bb View commit details
    Browse the repository at this point in the history
  10. docs: Update release note to reflect timelines

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    fe7a277 View commit details
    Browse the repository at this point in the history
  11. Release 3.2.0

    Another smaller release, this time with no new API versions.
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1d5c436 View commit details
    Browse the repository at this point in the history
  12. Post-release version bump

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8d204c0 View commit details
    Browse the repository at this point in the history
  13. Update reno for stable/3.2

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e2c37f1 View commit details
    Browse the repository at this point in the history
  14. docs: Fix typo

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    51581fa View commit details
    Browse the repository at this point in the history
  15. CI: Bump action versions

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7643453 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. templates/submission: Fix alignment of commit message

    Preformatted content must not be indented
    because any space is kept in the output,
    making the content wrongly indented.
    
    When aligning message headers to the left,
    the new HTML code has been indented
    including some preformatted content indented with two spaces.
    
    The fix is to remove the indent of the content.
    
    Signed-off-by: Thomas Monjalon <[email protected]>
    Fixes: fe34ab2 ("patch-detail: left align message headers")
    Reviewed-by: Robin Jarry <[email protected]>
    Reviewed-by: Stephen Finucane <[email protected]>
    tmonjalo authored and stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    13bbc0d View commit details
    Browse the repository at this point in the history
  2. CI: Cancel builds upon a new push

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    09939ba View commit details
    Browse the repository at this point in the history
  3. tests: Dump more info if version test fails

    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fa14cf8 View commit details
    Browse the repository at this point in the history
  4. css: make diff colors more accessible

    The colors used to display patch diffs are confusing. The context color
    is very similar to the added line color and the contrast between added
    and removed lines is very low.
    
    Originally, the choice of purple/blue (instead of the more common
    red/green palette) may have been made with colorblindness accessibility
    in mind. However, after inspecting the current colors with
    colorblindness "simulators", I found that the low contrast was
    consistent no matter what vision deficiency (if any) you might have.
    
    Update the colors to use a more common red/green palette. Add background
    colors to increase contrast for colorblind people. Use less confusing
    colors for context and diff hunks. Use normal line height to prevent
    background colors from overlapping. Use a different color for email
    quotes (blue) to avoid confusion with added lines.
    
    I have made a compilation of the current and updated color palette
    previews for normal vision and all common color deficiencies. I also
    included the same diff as seen from Github interface for reference.
    
    Link: http://files.diabeteman.com/patchwork-diff-colors/
    Signed-off-by: Robin Jarry <[email protected]>
    rjarry authored and stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c443cd9 View commit details
    Browse the repository at this point in the history
  5. models: Add covering index for Patch.hash

    Signed-off-by: Stephen Finucane <[email protected]>
    Closes: getpatchwork#579
    Cc: Mauro Carvalho Chehab <[email protected]>
    stephenfin committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    801e5bd View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. views: Switch logout to POST

    This was deprecated in 4.1 and removed in 5.0. I missed it.
    
    [1] https://docs.djangoproject.com/en/5.0/releases/4.1/#features-deprecated-in-4-1
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    45f47e9 View commit details
    Browse the repository at this point in the history
  2. views: Don't show chevron if user can't change sort order

    We prevent users changing the column that sorting is done on when
    allowing users to change the order of patches in a bundle. However, we
    still show a chevron and clicking the link will appear to do something.
    This is confusing/misleading. Remove the chevron and the link in this
    situation.
    
    Signed-off-by: Stephen Finucane <[email protected]>
    stephenfin committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6203264 View commit details
    Browse the repository at this point in the history
  3. views: Clean up patch-list page

    Add ids to table cells, and rename selectors using hyphen delimited
    strings to clean up and improve readability of patch-list.html. Also,
    create a partial template errors.html for errors that render with form
    submission.These changes make the code healthier, ready for change, and
    overall more readable.
    
    No user-visible change should be noticed.
    
    Signed-off-by: Raxel Gutierrez <[email protected]>
    Signed-off-by: Stephen Finucane <[email protected]>
    [stephenfin: Addressed merge conflicts and renamed some Python variables
                 in snake_case also]
    raxelg authored and stephenfin committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    09613eb View commit details
    Browse the repository at this point in the history
  4. views: Move js code to separate file

    Move patch-list related JS code to a new patch-list.js file, to
    make the JavaScript easy to read and change in one place. This makes
    automatic code formatting easier, makes it more straightforward to
    measure test coverage and discover opportunities for refactoring, and
    simplifies a possible future migration to TypeScript if the project
    chooses to go in that direction.
    
    No user-visible change should be noticed.
    
    Signed-off-by: Raxel Gutierrez <[email protected]>
    Signed-off-by: Stephen Finucane <[email protected]>
    [stephenfin: Addressed merged conflicts]
    raxelg authored and stephenfin committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0cea2e4 View commit details
    Browse the repository at this point in the history
  5. views: Move and refactor patch-forms

    Move patch forms in patch-list and detail page to a new template file
    patch-forms.html and move them to the top of the patch-list page to
    improve their discoverability.
    
    Refactor forms.py, __init__.py, patch.py, and test_bundles.py files so
    that the shared bundle form in patch-forms.html works for both the
    patch-list and patch-detail pages. In particular, the changes normalize
    the behavior of the error and update messages of the patch forms and
    updates tests to reflect the changes. Overall, these changes make patch
    forms ready for change and more synchronized in their behavior. More
    specifically:
    
    - Previously patch forms changes were separated between the patch-detail
      and patch-list pages. Thus, desired changes to the patch forms
      required changes to patch-list.html, submission.html, and forms.py.
      So, the most important benefit to this change is that forms.py and
      patch-forms.html become the two places to adjust the forms to handle
      form validation and functionality as well as UI changes.
    
    - Previously the patch forms in patch-list.html handled error and
      update messages through views in patch.py, whereas the patch forms in
      submission.html handled the messages with forms.py. Now, with a single
      patch forms component in patch-forms.html, forms.py is set to handle
      the messages and handle form validation for both pages.
    
    Signed-off-by: Raxel Gutierrez <[email protected]>
    Signed-off-by: Stephen Finucane <[email protected]>
    [stephenfin: Address merge conflicts]
    raxelg authored and stephenfin committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    17726d7 View commit details
    Browse the repository at this point in the history
  6. views: Style modification forms as an action bar

    Add styling to the new patch list html code to make the change property
    and bundle action forms more usable. Before [1] and after [2] images for
    reference.
    
    [1] https://i.imgur.com/Pzelipp.png
    [2] https://i.imgur.com/UtNJXuf.png
    
    Signed-off-by: Raxel Gutierrez <[email protected]>
    Signed-off-by: Stephen Finucane <[email protected]>
    [stephenfin: Addressed merge conflicts, tweak CSS slightly]
    raxelg authored and stephenfin committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8c7aed3 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. models: Add 'related_series' field to Series model

    Closes getpatchwork#506
    
    Signed-off-by: andrepapoti <[email protected]>
    andrepapoti committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a2cac80 View commit details
    Browse the repository at this point in the history
  2. serializers: Add 'related_versions' field to series serializer

    For two series to be linked togheter they must belong to the same project
    
    Closes getpatchwork#506
    
    Signed-off-by: andrepapoti <[email protected]>
    andrepapoti committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6e3d250 View commit details
    Browse the repository at this point in the history
  3. serializers: Optimize query performance on SeriesMixin for 'related_s…

    …eries'
    
    Ensure the retrival of series is keept at O(1) complexity.
    
    Closes getpatchwork#506
    
    Signed-off-by: andrepapoti <[email protected]>
    andrepapoti committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    14078c5 View commit details
    Browse the repository at this point in the history
  4. urls: Create endpoint to link two series

    Closes getpatchwork#506
    
    Signed-off-by: andrepapoti <[email protected]>
    andrepapoti committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e9c5545 View commit details
    Browse the repository at this point in the history
  5. tests: Add tests for linking series feature

    Closes getpatchwork#506
    
    Signed-off-by: andrepapoti <[email protected]>
    andrepapoti committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2ea356c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a91a667 View commit details
    Browse the repository at this point in the history