-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contribution at 14-07-2020 #18645
Open
Q-back
wants to merge
46
commits into
develop
Choose a base branch
from
contribute/14-07-2020
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,409
−639
Open
contribution at 14-07-2020 #18645
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
bf12c08
ignore __pychace__/ and another script file pattern (for tests)
Q-back fa7f743
automatically marked slow and deprecated tests, added pytest.ini
Q-back 3c26cf1
added pytest to tests requirements
Q-back 50cb5a5
brought back FormInputSubmitStrategy, better alghoritm of discovering…
Q-back 13a5d0d
fix _handle_authentication_success breaking parent's functionality in…
Q-back e04104f
revert enabling FormInputSubmitStrategy from pre-previous commit
Q-back 389646d
new options in autocomplete_js to manually provide username/submit bu…
Q-back 52b8f39
don't create new chrome instance when running autocomplete_js.has_act…
Q-back 2192ca5
fix after rebase
Q-back 1723b6b
reloading chrome when checking active session may break the session
Q-back b81b71d
implemented _login_using_existing_form
Q-back d4b6531
fix iterate error in frame manager, don't kill chrome in autocomplete…
Q-back 25a1125
better description for new params in autocomplete_js
Q-back 888eea6
sometimes login button doesn't contain 'log' characters in it's text,…
Q-back 27ede04
add option to click on element before autocompleting form
Q-back b76cf07
deleted conftest.py from root directory
Q-back c68a45a
remove unused pytest imports
Q-back f92a9ae
marked other failing tests
Q-back 04ec9bc
added tests to docs
Q-back 5854763
fix error when user provides CSS selectors with quotes. Slightly bett…
Q-back 0b8b3f0
fix UnicodeDecodeError when parsing openapi spec
Q-back 2e88cc2
fix request error when not required array param in open_api spec
Q-back 8d520bc
fix error when empty list was returned by querySelectorAll to Instrum…
Q-back 8cbbfa9
Merge branch 'fix/tests' into holm-master
Q-back ad54e10
Merge branch 'upstream-develop' into holm-master
Q-back fddafa2
Merge remote-tracking branch 'upstream/feature/improve-autocomplete_j…
Q-back ea9e923
fix typo in pytestmark
Q-back 5e49d49
function-based plugin runner
Q-back 9eb78c7
test runner class-based, prepared css selector test
Q-back d5a54f7
mocking network in plugin_runner, autocomplete_js reports CSS selecto…
Q-back 82710b5
cleanup plugin testing code
Q-back 470ba5e
Few comments about the code
Q-back 766a16b
create new kb instance every time kb fixture is used
Q-back b517f04
Merge branch 'feature/improve-report-autocomplete_js' into 'holm-master'
69ab174
SOAP plugin
6de1323
Merge branch 'feature/soap-plugin' into 'holm-master'
3dc8fc3
added Zeep to requirements
Q-back 7f9f578
refactored soap plugin to wsdl_parser
Q-back 6a6e5be
fixed DocumentParser process hanging for too long, fixed potential pi…
Q-back e9b5713
improve NetworkPatcher() context manager, added @patch_network decorator
Q-back fafed41
skip tests using internet
Q-back a81845f
refactored wsdl to force zeep using w3af http_client, extended_urllib…
Q-back 2d12caa
fixed test_cache
Q-back c3e0eec
submit strategy error will be saved to debug logs instead of error lo…
Q-back 1a063e2
ZeepTransport will save requests it performs, added get_fuzzable_requ…
Q-back 48b1545
report possible fuzzable requests from document parsers
Q-back File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix iterate error in frame manager, don't kill chrome in autocomplete…
…_js.has_active_session if chrome belongs to outer scope
commit d4b6531d78f3d492daf98c8ba8558db126987c9b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just added for debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added by purpose as I think it's good to have at least traceback saved when exception is silenced. If I wouldn't add this there would be no way to find this traceback as exception is silenced at this point. Showing only the exception name is not enough in many cases. How should be handled this one then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the context here, and if it will work, but we have an exception handler that will catch "all exceptions" and save them to a text file in /tmp.
Another alternative, if the scan can continue without a major reduction in functionality and user doesn't need to know about this issue is to also use
debug
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not this time. The exception is not propagated in this place, it's simply silenced.
Changed to
debug
according to your recommendation c3e0eec.