Downgrade Best.Conventional to target netstandard20 (rather than nets…

…tandard21 which excludes .NET Framework consumption) (#98)
andrewabest · Nov 4, 2024 · 75a6b3b · 75a6b3b
1 parent 458b234
commit 75a6b3b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/Core/Conventional.Tests/Conventional.Tests.csproj b/src/Core/Conventional.Tests/Conventional.Tests.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
     <Version>0.0.0.0</Version>
   </PropertyGroup>
 

diff --git a/src/Core/Conventional.Tests/Conventional/Conventions/ConventionSpecificationTests.cs b/src/Core/Conventional.Tests/Conventional/Conventions/ConventionSpecificationTests.cs
@@ -847,7 +847,7 @@ public HasImmutablePropertiesDerived(string[] names, int age)
 
             public string[] Names { get; }
 
-            public int Age { get; }
+            public new int Age { get; }
         }
 
         [Test]

diff --git a/src/Core/Conventional/Conventional.csproj b/src/Core/Conventional/Conventional.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>netstandard2.1</TargetFramework>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <PackageId>Best.Conventional</PackageId>
     <Title>Best.Conventional</Title>
     <Authors>Andrew Best</Authors>
@@ -13,6 +13,7 @@
     <Copyright>Copyright © 2017, Andrew Best</Copyright>
     <Version>0.0.0.0</Version>
     <PackageVersion>0.0.0.0</PackageVersion>
+    <LangVersion>8.0</LangVersion>
   </PropertyGroup>
   <ItemGroup>
     <None Remove="Conventions\Database\AllCheckConstraintsMustBeNamedConventionSpecification.sql" />
@@ -41,7 +42,6 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.CSharp" Version="4.4.1" />
     <PackageReference Include="Mono.Cecil" Version="0.10.0" />
-    <PackageReference Include="System.Data.Common" Version="4.3.0" />
-    <PackageReference Include="System.Data.SqlClient" Version="4.8.5" />
+    <PackageReference Include="System.Data.SqlClient" Version="4.8.6" />
   </ItemGroup>
 </Project>
diff --git a/src/Core/global.json b/src/Core/global.json
@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "3.1.000",
-    "rollForward": "minor"
+    "version": "8.0.303",
+    "rollForward": "feature"
   }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
                 public string[] Names { get; }
-                public int Age { get; }
+                public new int Age { get; }
             }
             [Test]
@@ Expand Down @@