Update deps #4
Open
Update deps #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pegaltier
force-pushed
the
update-deps
branch
3 times, most recently
from
137c127 to
29d85b9
Compare
pegaltier
commented
Dec 15, 2024
|
|
||
| // Buy if lowSMA crosses over the highSMA | ||
| if (lowSMA > highSMA) { | ||
| if (lowSMA[0] > highSMA[0]) { |
There was a problem hiding this comment.
safer to always return a list of number and use the one we want here
pegaltier
force-pushed
the
update-deps
branch
from
29d85b9 to
5ff1513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got error when trying to install the project because of tulind, i suggest replacing by a pure typescript implementation, it's probably slower but easier to install and onboard people on this project