Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Enzyme functionality for both the GPU and CPU #6

Merged
merged 75 commits into from
Sep 19, 2024
Merged

Add Enzyme functionality for both the GPU and CPU #6

merged 75 commits into from
Sep 19, 2024

Commits on Aug 22, 2024

  1. Applied autodiff to end-to-end run, isolated model computations into … 

    …a loop helper function of ocn_run. Had to temporarily comment out kernels, will re-add them
    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fdd4aa9 View commit details
    Browse the repository at this point in the history

  2. Modified kernels so they cooperate with AD and (I think) no longer re… 

    …quire @allowscalar macros. Still one summation that isn't working with AD
    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    45424fc View commit details
    Browse the repository at this point in the history

  3. Successful (non-erroring) end-to-end AD of shallow water model

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    208a0f2 View commit details
    Browse the repository at this point in the history

  4. Added measure of ssh

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7f94574 View commit details
    Browse the repository at this point in the history

  5. minor edits

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5d1de5c View commit details
    Browse the repository at this point in the history

  6. Removing uses of UnPack.jl due to incompatibility with Enzyme

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9adc0b9 View commit details
    Browse the repository at this point in the history

  7. Removed circshift call

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    905470a View commit details
    Browse the repository at this point in the history

  8. Tests show end-to-end AD aligns with FD results

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c75234b View commit details
    Browse the repository at this point in the history

  9. Expanded test across range of step sizes

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c5366e7 View commit details
    Browse the repository at this point in the history

  10. Restored ocen_timestep to resemble previous function handle

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0f179b7 View commit details
    Browse the repository at this point in the history

  11. Split regular forward run and AD run into different functions

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    07b17ea View commit details
    Browse the repository at this point in the history

  12. Added command line option for specifying AD run, preserves default fo… 

    …rward run otherwise
    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    88400ba View commit details
    Browse the repository at this point in the history

  13. Minor edits

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6544fb5 View commit details
    Browse the repository at this point in the history

  14. Re-added enz-rev branch of KA, set up GPU gradient test to avoid @all… 

    …owscalar or broadcasting in part that it differentiated
    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    45c9154 View commit details
    Browse the repository at this point in the history

  15. Updates

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    69d1cda View commit details
    Browse the repository at this point in the history

  16. Issue with e2e GPU run without AD

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    23ad15e View commit details
    Browse the repository at this point in the history

  17. Making GPU-friendly modifications

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    684b1ce View commit details
    Browse the repository at this point in the history

  18. Set up current manifest without Enzyme

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8c2113c View commit details
    Browse the repository at this point in the history

  19. Fixed compilation issue, but now results are slightly incorrect

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    93e86d4 View commit details
    Browse the repository at this point in the history

  20. Working and accurate GPU code

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5bee022 View commit details
    Browse the repository at this point in the history

  21. Back to GPU kernels working with AD

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fea6761 View commit details
    Browse the repository at this point in the history

  22. Progressing through GPU AD

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0801259 View commit details
    Browse the repository at this point in the history

  23. Progressing through GPU AD

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d9a461b View commit details
    Browse the repository at this point in the history

  24. Temporary fix for blocksize, running into bug with diagnostic variables

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9f5791e View commit details
    Browse the repository at this point in the history

  25. Made prognostic variables vectors of arrays instead of arrays

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f0bfd94 View commit details
    Browse the repository at this point in the history

  26. End to end GPU AD for diagnostic variable computations

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    746dfd9 View commit details
    Browse the repository at this point in the history

  27. Working on tendency computations

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    195cc0f View commit details
    Browse the repository at this point in the history

  28. Facing KA issue

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e94e753 View commit details
    Browse the repository at this point in the history

  29. Enabled Normal Velocity Tendency on GPU

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    41e1dd6 View commit details
    Browse the repository at this point in the history

  30. Making dt a length-1 array to avoid known limitations of KA AD

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6ad9396 View commit details
    Browse the repository at this point in the history

  31. Fixed some issues in GPU AD run, still need to figure out tendLayerTh… 

    …ickness
    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2492019 View commit details
    Browse the repository at this point in the history

  32. AD-enabled GPU version now produces results consistent with CPU versi… 

    …on. There are some issues with show_output.py, though
    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    33e6a47 View commit details
    Browse the repository at this point in the history

  33. GPU AD code runs but Nans

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8730f38 View commit details
    Browse the repository at this point in the history

  34. Still fguring out NaN issue

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6b7e537 View commit details
    Browse the repository at this point in the history

  35. Updated dependencies

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4cb499d View commit details
    Browse the repository at this point in the history

  36. Cleaning up Operator tests

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6cfd89a View commit details
    Browse the repository at this point in the history

  37. Cleaned up Operator tests, now they work on GPU

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2467e68 View commit details
    Browse the repository at this point in the history

  38. Modified divergence kernel

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9b34900 View commit details
    Browse the repository at this point in the history

  39. Changed some variable names to avoid errors

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    41cb0f1 View commit details
    Browse the repository at this point in the history

  40. Setting up end-to-end test with AD

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    84d57ec View commit details
    Browse the repository at this point in the history

  41. Setting up framework for end2end test

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    223b552 View commit details
    Browse the repository at this point in the history

  42. Working on dependencies

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c0db5a3 View commit details
    Browse the repository at this point in the history

  43. Updated dependencies

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5d23fb9 View commit details
    Browse the repository at this point in the history

  44. Edit

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    557cbbe View commit details
    Browse the repository at this point in the history

  45. Minor edits

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    011a975 View commit details
    Browse the repository at this point in the history

  46. Updated Enzyme dependency to 0.12.27 (latest version that doesn't error)

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    fb40820 View commit details
    Browse the repository at this point in the history

  47. Adding special copyto! rule

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    06bfd70 View commit details
    Browse the repository at this point in the history

  48. Adding custom rule extension for Enzyme

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a3711f6 View commit details
    Browse the repository at this point in the history

  49. Delete custom_rules.jl

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c18070e View commit details
    Browse the repository at this point in the history

  50. Rename custom_rules.jl to EnzymeExt.jl

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9a95fc7 View commit details
    Browse the repository at this point in the history

  51. added mycopyto! and its custom rule

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    07b4c36 View commit details
    Browse the repository at this point in the history

  52. Minor updates

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    aee657a View commit details
    Browse the repository at this point in the history

  53. Eliminated direct dependency on EnzymeCore

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    db66b26 View commit details
    Browse the repository at this point in the history

  54. Added end-2-end run to test file - still need to set up correct mesh … 

    …data to download for test
    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d3df21b View commit details
    Browse the repository at this point in the history

  55. Set up end-to-end enzyme test that runs forward model with AD, then c… 

    …ompares to FD approximation. The results are accurate for the CPU. GPU still NaN's with Enzyme, but produces consistent FD results with the CPU. Still need to host mesh data with a config file on a public repo to download to make the test complete
    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0c6c80a View commit details
    Browse the repository at this point in the history

  56. Moved helpers from driver to a new file, run_loop.jl, in forward dire… 

    …ctory
    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7797555 View commit details
    Browse the repository at this point in the history

  57. Separated test Project.toml files and Enzyme Extension

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    1abd09b View commit details
    Browse the repository at this point in the history

  58. Moved run with AD to test, added more dependencies to test env

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    198ee3f View commit details
    Browse the repository at this point in the history

  59. Rename EnzymeExt.jl to MPASEnzymeExt.jl

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b686f22 View commit details
    Browse the repository at this point in the history

  60. Renamed EnzymeExt to MPASEnzymeExt

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5909fe9 View commit details
    Browse the repository at this point in the history

  61. Added file connecting to mesh data and config's

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    61e22c6 View commit details
    Browse the repository at this point in the history

  62. Added data input to end2end test using Artifiacts

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    bcbba73 View commit details
    Browse the repository at this point in the history

  63. Removed Downloads dependency

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    3c43bf1 View commit details
    Browse the repository at this point in the history

  64. Minor edits

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9a6eede View commit details
    Browse the repository at this point in the history

  65. Adjusted kernels to work for multiple vertical layers again

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    680984f View commit details
    Browse the repository at this point in the history

  66. Adding CI

    @michel2323 @jlk9
    michel2323 authored and jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d0ecebf View commit details
    Browse the repository at this point in the history

  67. Editing config file

    @jlk9
    jlk9 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7c53a64 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Add @test, forward, and CPU backend

    @michel2323
    michel2323 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b9fe989 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #8 from jlk9/tests 

    Add @test, forward, and CPU backend
    @jlk9
    jlk9 authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    270f6a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Updated dependency versions and Julia version, modfied Enzyme operato… 

    …r test since forward mdoe on GPU no longer errors but still produces incorrect result
    @jlk9
    jlk9 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    36ebbb3 View commit details
    Browse the repository at this point in the history

  2. Updated dependencies in test project...

    @jlk9
    jlk9 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bab2332 View commit details
    Browse the repository at this point in the history

  3. vec edge forward mode test now produces correct results

    @jlk9
    jlk9 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c62f21c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Only do include once in runtests.jl file. 

    In order to avoid redefinitions of variables/function warnings.
    @andrewdnolan
    andrewdnolan committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6e7ffc5 View commit details
    Browse the repository at this point in the history

  2. Add statment to deal with variable scope

    @andrewdnolan
    andrewdnolan committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f7d43e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Remove unneeded python file

    @andrewdnolan
    andrewdnolan committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    18f7910 View commit details
    Browse the repository at this point in the history