Fix "Load Palette…" option #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around ccgus/CocoaScript#48, which was preventing the Open panel from appearing on macOS High Sierra 10.13 when selecting the "Load Palette…" option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around ccgus/CocoaScript#48, which was preventing the Open panel from appearing on macOS High Sierra 10.13 when selecting the "Load Palette…" option. Prior to this commit, the following error is logged to the Console app when attempting to load a palette:
Tangentially, since the same array values are used here, perhaps a
const ALLOWED_FILE_TYPES = ["sketchpalette"]would be more ideal.Anyway, thanks for this plugin. I use it whenever I design in Sketch.