Merge pull request #22 from longerd/dev · andrewmilson/ministark@ff5bf80

Message level	Amount
Internal compiler error	0
Error	0
Warning	49
Note	0
Help	0

Check warning on line 57 in src/stark.rs

github-actions / clippy

use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified

warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified
  --> src/stark.rs:57:5
   |
57 |     async fn prove(
   |     ^^^^^
   |
   = note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future`
   = note: `#[warn(async_fn_in_trait)]` on by default
help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change
   |
57 ~     fn prove(
58 |         &self,
59 |         options: ProofOptions,
60 |         witness: Self::Witness,
61 ~     ) -> impl std::future::Future<Output = Result<Proof<Self>, ProvingError>> + Send {async {
62 |         default_prove(self, options, witness)
63 ~     } }
   |

Check warning on line 60 in src/verifier.rs

github-actions / clippy

using `map` over `inspect`

warning: using `map` over `inspect`
  --> src/verifier.rs:60:65
   |
60 |     let extension_trace_commitment = extension_trace_commitment.map(|commitment| {
   |                                                                 ^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
   = note: `#[warn(clippy::manual_inspect)]` implied by `#[warn(clippy::all)]`
help: try
   |
60 ~     let extension_trace_commitment = extension_trace_commitment.inspect(|commitment| {
61 ~         public_coin.reseed_with_digest(commitment);
   |

Check warning on line 648 in src/utils.rs

github-actions / clippy

first doc comment paragraph is too long

warning: first doc comment paragraph is too long
   --> src/utils.rs:633:5
    |
633 | /     /// Generates a single column matrix consisting of two values i.e.
634 | |     /// ┌───────┐
635 | |     /// │ Col 0 │
636 | |     /// ├───────┤
...   |
647 | |     /// │ ...   │
648 | |     /// └───────┘
    | |____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
help: add an empty line
    |
633 ~     /// Generates a single column matrix consisting of two values i.e.
634 +     ///
635 ~     /// ┌───────┐
    |

Check warning on line 616 in src/utils.rs

github-actions / clippy

first doc comment paragraph is too long

warning: first doc comment paragraph is too long
   --> src/utils.rs:605:5
    |
605 | /     /// Generates a matrix of fibbonacci sequence across two columns i.e.
606 | |     /// ┌───────┬───────┐
607 | |     /// │ Col 0 | Col 1 │
608 | |     /// ├───────┼───────┤
...   |
615 | |     /// │ ...   │ ...   │ ...
616 | |     /// └───────┴───────┘
    | |____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
    = note: `#[warn(clippy::too_long_first_doc_paragraph)]` implied by `#[warn(clippy::nursery)]`
help: add an empty line
    |
605 ~     /// Generates a matrix of fibbonacci sequence across two columns i.e.
606 +     ///
607 ~     /// ┌───────┬───────┐
    |

Check warning on line 183 in src/prover.rs

github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
   --> src/prover.rs:183:28
    |
183 | /// Bit reverses the first ce_domain_size many values of the matrix columns.
    |                            ^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
   --> src/lib.rs:1:22
    |
1   | #![warn(clippy::all, clippy::pedantic, clippy::cargo, clippy::nursery)]
    |                      ^^^^^^^^^^^^^^^^
    = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
    |
183 | /// Bit reverses the first `ce_domain_size` many values of the matrix columns.
    |                            ~~~~~~~~~~~~~~~~

Check warning on line 31 in src/matrix.rs

github-actions / clippy

this could be a `const fn`

warning: this could be a `const fn`
  --> src/matrix.rs:29:5
   |
29 | /     pub fn new(cols: Vec<GpuVec<F>>) -> Self {
30 | |         Self(cols)
31 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn
help: make the function `const`
   |
29 |     pub const fn new(cols: Vec<GpuVec<F>>) -> Self {
   |         +++++

Check warning on line 90 in src/fri.rs

github-actions / clippy

this could be a `const fn`

warning: this could be a `const fn`
  --> src/fri.rs:85:5
   |
85 | /     pub fn new(layers: Vec<LayerProof<F, D, M>>, remainder_coeffs: Vec<F>) -> Self {
86 | |         Self {
87 | |             layers,
88 | |             remainder_coeffs,
89 | |         }
90 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_fn
help: make the function `const`
   |
85 |     pub const fn new(layers: Vec<LayerProof<F, D, M>>, remainder_coeffs: Vec<F>) -> Self {
   |         +++++

Check warning on line 2313 in /rustc/03ee4845197ce71aa5ee28cb937a3e863b18b42f/library/core/src/ptr/mod.rs

github-actions / clippy

temporary with significant `Drop` in `if let` scrutinee will live until the end of the `if let` expression

warning: temporary with significant `Drop` in `if let` scrutinee will live until the end of the `if let` expression
   --> src/expression.rs:127:37
    |
127 |         if let Some(node) = sn.get(&addr_of!(*this.read().unwrap())) {
    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
131 |             let res = Arc::new(RwLock::new(match &*this.read().unwrap() {
    |                                                    -------------------- another value with significant `Drop` created here
...
139 |                     sn.insert(addr_of!(*this.read().unwrap()), Arc::clone(&res));
    |                                         -------------------- another value with significant `Drop` created here
...
157 |             sn.insert(addr_of!(*this.read().unwrap()), Arc::clone(&res));
    |                                 -------------------- another value with significant `Drop` created here
158 |             res
159 |         }
    |          - temporary lives until here
    |
    = note: this might lead to deadlocks or other unexpected behavior
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#significant_drop_in_scrutinee
    = note: `#[warn(clippy::significant_drop_in_scrutinee)]` implied by `#[warn(clippy::nursery)]`
    = note: this warning originates in the macro `addr_of` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 474 in src/eval_cpu.rs