Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a bug with some stranger bytes in date conversion and copy file as default #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

berlotto
Copy link

@berlotto berlotto commented Dec 4, 2014

No description provided.

@andrewning
Copy link
Owner

I consciously made move the default behavior because this is how the script primarily used. The move operation is atomic so it's not really any less safe.

On Thu, Dec 4, 2014 at 9:29 AM, Sérgio H. Berlotto Jr
[email protected] wrote:

You can merge this Pull Request by running:
git pull https://github.com/berlotto/sortphotos master
Or you can view, comment on it, or merge it online at:
#32
-- Commit Summary --

@andrewning
Copy link
Owner

Could you send me one of the photos that causes the null bytes issue for you?  I want to see where the root is and if it's possible that other fields could have these issues. Thanks for your contribution.

On Thu, Dec 4, 2014 at 7:10 PM, null [email protected] wrote:

I consciously made move the default behavior because this is how the script primarily used. The move operation is atomic so it's not really any less safe.
On Thu, Dec 4, 2014 at 9:29 AM, Sérgio H. Berlotto Jr
[email protected] wrote:

You can merge this Pull Request by running:
git pull https://github.com/berlotto/sortphotos master
Or you can view, comment on it, or merge it online at:
#32
-- Commit Summary --

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants