Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Add veryFineDustSensor Capability #76

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

LeeHanYeong
Copy link

https://developer.smartthings.com/docs/devices/capabilities/capabilities-reference/#veryFineDustSensor
It indicates the level of very-fine dust (PM1.0) in air monitors, air purifiers, and air conditioners.

Description:

Related issue (if applicable): fixes #

Checklist:

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • Tests have been added/updated and code coverage percentage does not drop. No exclusions in .coveragerc allowed
  • README.MD updated (if necessary)

https://developer.smartthings.com/docs/devices/capabilities/capabilities-reference/#veryFineDustSensor
It indicates the level of very-fine dust (PM1.0) in air monitors, air purifiers, and air conditioners.
@baawiki
Copy link

baawiki commented Sep 10, 2023

Hi @LeeHanYeong!

I came here for the same thing :)

I've sent GH-78 which adds veryFineDustLevel as an attribute to the single dustSensor, that seems to be consistent with how the existing dustLevel and fineDustLevel attributes are implemented.

Hopefully at least one of our PRs will get accepted :)

@baawiki
Copy link

baawiki commented Sep 11, 2023

@LeeHanYeong just following the earlier comment, I've dropped my pull request as we don't need two for the same feature.

The only thing I see missing from yours is an update on the CAPABILITIES_TO_ATTRIBUTES map. I think you need to add:

"veryFineDustSensor": ["veryFineDustLevel"],

somewhere around line 140.

HTH!

Copy link
Owner

@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @LeeHanYeong! As @baawiki mentioned, there's one additional update needed in the CAPABILITIES_TO_ATTRIBUTES map. Once edited there, this is good to go!

@LeeHanYeong
Copy link
Author

@baawiki Thanks for the help with the missing code.
@andrewsayre I added the above code to my PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants