Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Nebius AI Studio added #138

Merged
merged 5 commits into from
Dec 29, 2024
Merged

Conversation

Aktsvigun
Copy link
Contributor

Hey team,

Thanks for a great framework! Adding integration with Nebius AI Studio, which provides access to state-of-the-art models.

@Aktsvigun
Copy link
Contributor Author

@ksolo may I kindly ask you to review it before it diverges too much from the main? thanks!


provider = NebiusProvider()
print(provider.api_key)
response = provider.chat_completions_create(model=selected_model, messages=message_history, top_p=chosen_top_p)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aktsvigun We have been mocking the interaction with the providers. If you look at an example like this one (https://github.com/andrewyng/aisuite/blob/main/tests/providers/test_sambanova_provider.py) we are mostly testing the setup more so than the actual result.

Can you update this to follow that pattern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, fixed! Kindly check.
I've standardized the test according to the example you sent & modified the NebiusProvider to match most of other providers (e.g. Mistral, Sambanova, etc.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend resetting the notebook so the outputs are all clean when committing these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please specify what outputs you reference? In this notebook (examples/client.ipynb) I can see no outputs.

@Aktsvigun
Copy link
Contributor Author

@ksolo could you please approve? Fixed all your suggestions.

@ksolo
Copy link
Collaborator

ksolo commented Dec 29, 2024

@Aktsvigun apologies on the delay I was traveling for the holidays.

@ksolo
Copy link
Collaborator

ksolo commented Dec 29, 2024

@Aktsvigun Can you open a follow up PR with documentation? Examples can be found here (https://github.com/andrewyng/aisuite/tree/main/guides)

@ksolo ksolo merged commit c191980 into andrewyng:main Dec 29, 2024
4 checks passed
@Aktsvigun
Copy link
Contributor Author

Hi @ksolo, thank you! Sure, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants