Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search-by-string on key function #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add search-by-string on key function #96

wants to merge 1 commit into from

Conversation

doublejosh
Copy link

Allows searching items by key using a string.

$.jStorage.search('my-namespace-values');

@doublejosh
Copy link
Author

Needs testing, adapted from my current addon, related to this issue... #52

@andris9
Copy link
Owner

andris9 commented Aug 12, 2015

This approach assumes that jQuery is present while jStorage does not. Would it be possible to do the same thing but without $.extend (and also add a test for it here)?

There's also an awesome fulltext search library for js called lunr.js but I guess for this specific task it would be an overkill.

@doublejosh
Copy link
Author

Zepto has extend in it's core too. Are there other candidate dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants