This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
more robust switch actions in pgp settings #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
suggested changes
Aug 3, 2024
|
Changes LGTM bar the stylistic nits, I'll test and merge this over the weekend. |
Co-authored-by: Harsh Shandilya <[email protected]> Signed-off-by: agrahn <[email protected]>
Co-authored-by: Harsh Shandilya <[email protected]> Signed-off-by: agrahn <[email protected]>
Co-authored-by: Harsh Shandilya <[email protected]> Signed-off-by: agrahn <[email protected]>
agrahn
commented
Aug 3, 2024
msfjarvis
approved these changes
Aug 4, 2024
Merged
via the queue into
android-password-store:develop
with commit Aug 4, 2024
17a8bbc
6 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PGP cache settings switches have been robustified a bit more. Now, every enable/disable action of the passphrase cache clears the same to enhance safety. This requires biom. authentification every time. If it fails (error/cancellation) the previous state is reverted to. Moreover,
onClicklistener is now used instead ofonCheckedChangebecause the correct switch state is rendered immediately after the action has completed (esp. after auth cancellatiion by the user).