This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
fix blocking createPasswordUI() when OTP is displayed #3162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the decrypted entry in the store contains an OTP, function
createPasswordUI()
becomes a blocking function. In this case,startAutoDismissTimer()
andonSuccess()
that come aftercreatePasswordUI()
in functiondecryptWithPassphrase()
are not reached and executed. As a consequence, passphrase caching is not carried out and the passphrase must be entered again in order to decrypt another entry in the store.The bug can be reproduced as follows:
This PR tries to fix the issue.