Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

fix blocking createPasswordUI() when OTP is displayed #3162

Merged

Conversation

agrahn
Copy link
Contributor

@agrahn agrahn commented Aug 10, 2024

If the decrypted entry in the store contains an OTP, function createPasswordUI() becomes a blocking function. In this case, startAutoDismissTimer() and onSuccess() that come after createPasswordUI() in function decryptWithPassphrase() are not reached and executed. As a consequence, passphrase caching is not carried out and the passphrase must be entered again in order to decrypt another entry in the store.

The bug can be reproduced as follows:

  1. Start APS, ensure that passphrase caching and auto-clean on screen-off are enabled.
  2. Select a store entry with an OTP, unlock the cache with the screen-lock PIN and decrypt the entry with your passphrase
  3. Select another (or the same) entry from the password list
  4. Enter the PIN --> APS asks again for your passphrase, which should not be necessary if the previously entered passphrase were cached properly.

This PR tries to fix the issue.

@msfjarvis msfjarvis added C-bug Category: This is a bug P-high Priority: high, must be resolved before next major release A-UI-UX Area: General UI/UX concerns labels Aug 11, 2024
@msfjarvis msfjarvis added this to the v2.0.0 milestone Aug 11, 2024
@msfjarvis msfjarvis added this pull request to the merge queue Aug 11, 2024
Merged via the queue into android-password-store:develop with commit d625163 Aug 11, 2024
6 checks passed
@agrahn agrahn deleted the createpassworduifix branch August 11, 2024 06:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-UI-UX Area: General UI/UX concerns C-bug Category: This is a bug P-high Priority: high, must be resolved before next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants