[Jetcaster] UI polish of TV module and resolved navigation & focus traversal issue in player screen #1481
Conversation
# Conflicts: # Jetcaster/gradle/libs.versions.toml
pflammertsma
requested review from
dturner and
chikoski
and removed request for
dturner
| @@ -72,8 +72,18 @@ private fun EpisodeThumbnail( | |||
| Card( | |||
| onClick = onClick, | |||
| interactionSource = interactionSource, | |||
| scale = CardScale.None, | |||
| scale = CardDefaults.scale(scale = 0.85f, focusedScale = 1.0f), | |||
There was a problem hiding this comment.
Scaling is intentionally disabled. We should keep the original intention.
| @@ -40,8 +41,18 @@ internal fun PodcastCard( | |||
| Card( | |||
| onClick = onClick, | |||
| interactionSource = it, | |||
| scale = CardScale.None, | |||
| shape = CardDefaults.shape(RoundedCornerShape(12.dp)) | |||
| scale = CardDefaults.scale(scale = 0.9f, focusedScale = 1.0f), | |||
There was a problem hiding this comment.
Scaling is intentionally disabled. Would you keep the original code?
| shape = CardDefaults.shape(RoundedCornerShape(12.dp)), | ||
| border = CardDefaults.border( | ||
| focusedBorder = Border( | ||
| border = _root_ide_package_.androidx.compose.foundation.BorderStroke( |
There was a problem hiding this comment.
Can you add androidx.compse.foundation.BorderStroke to import section and refer the imported symbol here?
| shape = CardDefaults.shape(RoundedCornerShape(16.dp)), | ||
| border = CardDefaults.border( | ||
| focusedBorder = Border( | ||
| border = _root_ide_package_.androidx.compose.foundation.BorderStroke( |
There was a problem hiding this comment.
Can you add androidx.compse.foundation.BorderStroke to import section and refer the imported symbol here?
| @@ -347,6 +348,10 @@ private fun PlayerControl( | |||
| modifier = Modifier | |||
| .size(JetcasterAppDefaults.iconButtonSize.large.intoDpSize()) | |||
| .focusRequester(playPauseButton) | |||
| .onGloballyPositioned { | |||
There was a problem hiding this comment.
I believe the onGloballyPositioned modifier as PlayPauseButton is always in the viewport.
| @@ -361,6 +366,12 @@ private fun PlayerControl( | |||
| ElapsedTimeIndicator(timeElapsed, length, skip, rewind) | |||
| } | |||
| } | |||
| LaunchedEffect(isSafeToSetInitialFocus) { | |||
There was a problem hiding this comment.
We can call playPauseButton.requestFocus without checking isSafeToInitialFocus flag.
No description provided.