Make MediaCodecVideoRenderer::shouldUsePlaceholderSurface protected. #1905
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a derived renderer to disable the placeholder surface.
Not having a placeholder surface allows to delay instantiating the codecs until we have a surface. This allows to have more players ready without having their decoders loaded.
This follows the mode that
shouldUseDetachedSurface
is protected and overridable by a derived class.Since
getSurfaceForCodec
must callhasSurfaceForCodec
, the check for the placeholder surface ingetSurfaceForCodec
should not trigger if we disable the placeholder surface ashasSurfaceForCodec
would have returned false.