Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show video track selectors on PlayerControlView #972

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: show video track selectors on PlayerControlView #972

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89cb611
feat: show video track selectors on PlayerControlView
xeinebiu Jan 14, 2024
2f307bc
Update PlayerControlView.java
xeinebiu Jan 20, 2024
188cfb6
Format with google-java-format
microkatz Jan 26, 2024
6d010f8
Added release notes for PlayerControlView video track selection
microkatz Jan 26, 2024
0eea10c
Added AOSP Header in new drawable xml file
microkatz Jan 26, 2024
4614579
Moved exo_ic_videotrack.xml file to correct folder
microkatz Jan 26, 2024
5a57345
Added back linter and copybara comments that were removed
microkatz Jan 26, 2024
e12345c
Correcting some processing comments
microkatz Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions libraries/ui/src/main/java/androidx/media3/ui/PlayerControlView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@
public class PlayerControlView extends FrameLayout {

static {
MediaLibraryInfo.registerModule("media3.ui");
MediaLibraryInfo.registerModule("media3.ui"); // copybara:media3-only
// copybara:exo-only MediaLibraryInfo.registerModule("goog.exo.ui");
xeinebiu marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down Expand Up @@ -261,10 +262,10 @@ public interface OnFullScreenModeChangedListener {
// LINT.IfChange(playback_speeds)
private static final float[] PLAYBACK_SPEEDS =
new float[] {0.25f, 0.5f, 0.75f, 1f, 1.25f, 1.5f, 2f};

// LINT.ThenChange("../../../../res/values/strings.xml:playback_speeds")

private static final int SETTINGS_PLAYBACK_SPEED_POSITION = 0;
private static final int SETTINGS_AUDIO_TRACK_SELECTION_POSITION = 1;

private static final int SETTINGS_VIDEO_TRACK_SELECTION_POSITION = 2;

private final PlayerControlViewLayoutManager controlViewLayoutManager;
Expand Down