Add warnings for future deprecation of nixos options related to packaging #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbaur
force-pushed
the
rm-override-options
branch
from
d1a9bd5 to
dac11f6
Compare
Collaborator
|
Instead of simply removing these options, I think we should throw a warning when they are used, but remove them entirely at some later date. Optimally, we would also have documented an example of a way to do what one of these options did, but using an overlay. |
jmbaur
force-pushed
the
rm-override-options
branch
from
dac11f6 to
3ebff61
Compare
Contributor
Author
Added warnings here to warn of future deprecation: https://github.com/anduril/jetpack-nixos/pull/223/files#diff-826389d2e36b4094c8a2ab49d67b8d6ea42e488fba7b3c58c67ccd4a553011f8R357 |
jmbaur
changed the title
jmbaur
force-pushed
the
rm-override-options
branch
3 times, most recently
from
820832d to
12f5f22
Compare
This splits out uefi-firmware into multiple derivations to allow for easier overriding of individual components. This will eventually allow for the removal of nixos options that override these components, as overlays are now easier to use.
This splits out optee-related packages into multiple derivations to allow for easier overriding of individual components. This will eventually allow for the removal of nixos options that override these components, as overlays are now easier to use.
jmbaur
force-pushed
the
rm-override-options
branch
from
12f5f22 to
d5c6b20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We have a few nixos options that are mirrors of arguments to
stdenv.mkDerivation(e.g.patches,postPatch). Let's encourage users to use the overlay system in order customize packaging. This also includes some refactors of optee and uefi packages to allow for overlaying these derivations to be simpler.Testing
Tested using internal test suite (flashing, booting, capsule updates, etc) on an orin-nano-devkit