-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ComponentService.Get methods #389
Conversation
8b3d84e
to
9ce35df
Compare
@andygrunwald any idea why the actions are not available for this PR? |
@benjivesterby No idea, sorry. never saw it like this. What do you think about:
This should trigger the actions. |
Hey, I am very sorry that this pull request has been open for a long time with no final feedback or merge/decline. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma. However, there is news: We are kicking off v2 of this library 🚀To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489 The development will take some time; however, I hope you can benefit from the changes. What does this mean for my pull request?We will work on this pull request indirectly. Final wordsThanks for using and contributing to this library. |
Hey @krrishd, Thanks again for this pull request. In the recent time, I made various changes to this library (mainly to prep for v2). Hence, your code was not 100% reusable anymore. Thanks again! Components.Get is now part of the cloud package. |
Description
Hi!
What: Added a
Get
andGetWithContext
method forComponentService
Why: to be able to use
go-jira
to get Project Components (functionality that currently exists in the REST API but not in the library)Type of change: New feature + tests
Also added tests/mock data that effectively mirrors the way we've tested
Get
/GetWithContext
inProjectService
.Issue: This might relate to #361
JIRA version + type: Should work with all JIRA REST API v2, I specifically confirmed with on-prem + 8.17.1 (though I think this feature has been available for much longer)
Example:
Let us know how users can use or test this functionality.
Checklist