Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComponentService.Get methods #389

Closed
wants to merge 1 commit into from

Conversation

krrishd
Copy link

@krrishd krrishd commented Jul 21, 2021

Description

Hi!

What: Added a Get and GetWithContext method for ComponentService
Why: to be able to use go-jira to get Project Components (functionality that currently exists in the REST API but not in the library)
Type of change: New feature + tests
Also added tests/mock data that effectively mirrors the way we've tested Get/GetWithContext in ProjectService.
Issue: This might relate to #361
JIRA version + type: Should work with all JIRA REST API v2, I specifically confirmed with on-prem + 8.17.1 (though I think this feature has been available for much longer)

Example:

Let us know how users can use or test this functionality.

component, res, err := jiraClient.Component.Get("12345") // 12345 being a component ID, which you can find by going to a list of components, inspecting element, and looking for a data-component-id

Checklist

@krrishd krrishd changed the title Added ComponentService.Get methods Add ComponentService.Get methods Jul 21, 2021
@benjivesterby
Copy link
Collaborator

@andygrunwald any idea why the actions are not available for this PR?

@andygrunwald
Copy link
Owner

@benjivesterby No idea, sorry. never saw it like this.

What do you think about:

  1. Applying this change in a local setup
  2. Recreating a new branch
  3. Pushing it as a new PR

This should trigger the actions.

@andygrunwald
Copy link
Owner

Hey,

I am very sorry that this pull request has been open for a long time with no final feedback or merge/decline. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your pull request + you like to sponsor it, please contact me.

What does this mean for my pull request?

We will work on this pull request indirectly.
We might merge it during the development or pull parts of it into the new version.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using and contributing to this library.
If there is anything else you would like to tell us, let us know!

@github-actions github-actions bot added the conflicts Indicates merge conflicts label Sep 11, 2022
andygrunwald added a commit that referenced this pull request Oct 19, 2022
Thanks goes to @krrishd for his early work in
#389
@andygrunwald
Copy link
Owner

Hey @krrishd,

Thanks again for this pull request. In the recent time, I made various changes to this library (mainly to prep for v2). Hence, your code was not 100% reusable anymore.
I used it as the foundation and made it work in #583 again.

Thanks again! Components.Get is now part of the cloud package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Indicates merge conflicts waiting for feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants