Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and examples for Bearer Auth #469

Conversation

stxphcodes
Copy link

Description

  • The What: Added Bearer authentication example to the examples/ directory and updated Readme to add Bearer (PAT's) to the list of support authentication schemes.

  • The Why: Our team uses Personal Access Tokens to authenticate our external apps. I thought I was not able to use the go-jira library because it wasn't apparent from the README that Bearer was a supported authentication scheme. It was serendipitous that I went into the code and saw the section for Bearer Auth (added in this commit ) that I realized we could indeed use the go-jira Jira Client for our apps.

  • Type of change: Documentation

  • Breaking change: No

  • Related to an issue: n/a

  • Jira Version + Type: PATs were introduced in Jira v8.14 - for self-hosted Jira instances.

@andygrunwald
Copy link
Owner

Hey,

I am very sorry that this pull request has been open for a long time with no final feedback or merge/decline. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489

The development will take some time; however, I hope you can benefit from the changes.
If you seek priority development for your pull request + you like to sponsor it, please contact me.

What does this mean for my pull request?

We will work on this pull request indirectly.
We might merge it during the development or pull parts of it into the new version.
This means that during the development phase, we aim to tackle it.
Maybe in a different way like it is currently handled.
Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using and contributing to this library.
If there is anything else you would like to tell us, let us know!

@github-actions github-actions bot added the conflicts Indicates merge conflicts label Aug 25, 2022
andygrunwald added a commit that referenced this pull request Oct 19, 2022
@andygrunwald
Copy link
Owner

Hey @stxphcodes,

thanks again for your pull request.
Since opening this PR, I made a lot of changes to this project.
Thats why I was not able to re-use your commit directly.

However, I re-used your submission in #586 and implemented in the current form.

I attributed the commit message also to you.
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Indicates merge conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants