Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again.
I modified the implementation of
SmallBox<T>
to make it covariant overT
, by replacing the inner pointer from*mut
to*const
.It's worth noting that we have to be careful with the
*const
pointer, to not do something like&mut T as *const T
, which results in a non-writable pointer (basically expands to&mut T as &T as *const T
instead of&mut T as *mut T as *const T
), but I didn't see anything like that in the codebase, as we are using thealloc
crate which gives*mut u8
directly.