Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swift 3 Support. #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pratik6554
Copy link

No description provided.

@andymatuschak
Copy link
Owner

Hi, @pratik6554! Thanks so much for doing this.

I'd love to see this repository updated to Swift 3. My primary concern with these changes as they are is that the delta between the refactoring steps (represented by the separate commits) is really key… and each of those steps will remain in Swift 2. Only the final commit will be represented in Swift 3.

I feel the "right" way to re-create the multiple steps would be to essentially port each individual refactoring step over to Swift 3. We could represent that by a series of branches, instead of a series of commits, for ease… or it might even be easier to create a whole separate repository. If you'd like to create a series of branches representing each commit, I'd be very happy to review and merge them; or if you'd like to recreate a whole separate repository with a new history, and with each commit representing one refactoring step, I'd be happy to redirect readers of this repository to that one!

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants