Updated tests to cover 100%

.gitignore

@@ -1,5 +1,6 @@
 vendor/*
 .idea/*
-docs/samples/*
+samples/*
 logs/*
-composer.lock
+composer.lock
+build/*

tests/Message/CompletePurchaseRequestTest.php

@@ -2,7 +2,6 @@
 
 namespace Omnipay\Paynl\Test\Message;
 
-
 use Omnipay\Paynl\Message\Request\CompletePurchaseRequest;
 use Omnipay\Paynl\Message\Response\CompletePurchaseResponse;
 use Omnipay\Tests\TestCase;
@@ -43,6 +42,36 @@ public function testSendSuccessVerify()
         $this->assertEquals(1, $response->getAmount(), 'Amount should be 1 USD');
         $this->assertEquals('USD', $response->getCurrency(), 'Amount should be 1 USD');
     }
+    public function testReturn(){
+        $transactionId = uniqid();
+        $_GET['orderId'] = $transactionId;
+
+        $data = $this->request->getData();
+
+        $this->assertEquals($transactionId, $data['transactionId']);
+
+        //unset to prevent influencing other tests
+        unset($_GET['orderId']);
+    }
+    public function testExchange(){
+        $transactionId = uniqid();
+        $_REQUEST['order_id'] = $transactionId;
+
+        $data = $this->request->getData();
+
+        $this->assertEquals($transactionId, $data['transactionId']);
+
+        //unset to prevent influencing other tests
+        unset($_REQUEST['order_id']);
+    }
+
+    /**
+     * @expectedException Omnipay\Common\Exception\InvalidRequestException
+     */
+    public function testNoTransactionId(){
+
+        $this->request->getData();
+    }
 
     protected function setUp()
     {

tests/Message/FetchPaymentMethodsRequestTest.php

@@ -31,6 +31,19 @@ public function testSendSuccess()
         $this->assertContainsOnlyInstancesOf(PaymentMethod::class, $paymentMethods);
     }
 
+    public function testSendError()
+    {
+        $this->setMockHttpResponse('FetchPaymentMethodsError.txt');
+
+        $response = $this->request->send();
+
+        $this->assertInstanceOf(FetchPaymentMethodsResponse::class, $response);
+        $this->assertFalse($response->isSuccessful());
+
+        $this->assertNotEmpty($response->getMessage());
+        $this->assertNull($response->getPaymentMethods());
+    }
+
     protected function setUp()
     {
         $this->request = new FetchPaymentMethodsRequest($this->getHttpClient(), $this->getHttpRequest());

tests/Mock/FetchPaymentMethodsError.txt

@@ -0,0 +1,25 @@
+HTTP/1.1 200 OK
+Date: Thu, 18 Oct 2018 14:46:07 GMT;
+Server: Apache;
+Expires: Mon, 26 Jul 1990 05:00:00 GMT;
+Last-Modified: Thu, 18 Oct 2018 14:46:07 GMT;
+Cache-Control: post-check=0, pre-check=0;
+Pragma: no-cache;
+X-Frame-Options: SAMEORIGIN;
+X-XSS-Protection: 1; mode=block;
+X-Content-Type-Options: nosniff;
+Content-Length: 145;
+Connection: close;
+Content-Type: application/json;
+
+{
+    "request": {
+        "result": "0",
+        "errorId": "PAY-404",
+        "errorMessage": "Service not found"
+    },
+    "merchant": "",
+    "service": "",
+    "settings": "",
+    "countryOptionList": ""
+}