Skip to content

Commit

Permalink
Merge pull request kubernetes-csi#652 from davhdavh/fix-csi-win-defaults
Browse files Browse the repository at this point in the history 
Fix: wrong defaults and defaults not matching stated defaults
  • Loading branch information
@k8s-ci-robot
k8s-ci-robot authored Aug 18, 2023
2 parents 449a184 + ca7d2ab commit 7bc1087
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
16 changes: 8 additions & 8 deletions charts/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ The following table lists the configurable parameters of the latest SMB CSI Driv
| `securityContext` | security context to be added to pods | `{ seccompProfile: {type: RuntimeDefault} }` |
| `controller.name` | name of driver deployment | `csi-smb-controller` |
| `controller.replicas` | replica num of csi-smb-controller | `1` |
| `controller.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` | `ClusterFirstWithHostNet` |
| `controller.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` | `ClusterFirstWithHostNet` |
| `controller.metricsPort` | metrics port of csi-smb-controller | `29644` |
| `controller.livenessProbe.healthPort ` | health check port for liveness probe | `29642` |
| `controller.logLevel` | controller driver log level | `5` |
Expand Down Expand Up @@ -100,7 +100,7 @@ The following table lists the configurable parameters of the latest SMB CSI Driv
| `node.nodeSelector` | node pod node selector | `{}` |
| `linux.enabled` | whether enable linux feature | `true` |
| `linux.dsName` | name of driver daemonset on linux | `csi-smb-node` |
| `linux.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` | `ClusterFirstWithHostNet` |
| `linux.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` | `ClusterFirstWithHostNet` |
| `linux.kubelet` | configure kubelet directory path on Linux agent node node | `/var/lib/kubelet` |
| `linux.resources.livenessProbe.limits.memory` | liveness-probe memory limits | `100Mi` |
| `linux.resources.livenessProbe.requests.cpu` | liveness-probe cpu requests limits | `10m` |
Expand Down Expand Up @@ -135,12 +135,12 @@ The following table lists the configurable parameters of the latest CSI-proxy Dr
|---------------------------------------------------------|------------------------------------------------------------------------------------------------------------|---------------------------------------------------------|
| `windows.csiproxy.enabled` | whether enable csi-proxy daemonset | `false` |
| `windows.csiproxy.dsName` | name of driver csi-proxy daemonset on windows | `csi-proxy-win` |
| `windows.csiproxy.username` | name of windows user on the host machine to run the proxy as | `NT AUTHORITY\\SYSTEM` |
| `windows.csiproxy.affinity` | controller pod affinity | `{}` |
| `windows.csiproxy.nodeSelector` | controller pod node selector | `{"kubernetes.io/os": windows}` |
| `windows.csiproxy.tolerations` | controller pod tolerations | `[]` |
| `image.csiproxy.repository` | csiproxy docker image | `ghcr.io/kubernetes-sigs/sig-windows/csi-provisioner` |
| `image.csiproxy.tag` | csiproxy docker image tag | `v1.1.2` |
| `windows.csiproxy.username` | name of windows user on the host machine to run the proxy as | `NT AUTHORITY\\SYSTEM` |
| `windows.csiproxy.affinity` | controller pod affinity | `{}` |
| `windows.csiproxy.nodeSelector` | controller pod node selector | `{"kubernetes.io/os": windows} |
| `windows.csiproxy.tolerations` | controller pod tolerations | `[]` |
| `image.csiproxy.repository` | csiproxy docker image | `ghcr.io/kubernetes-sigs/sig-windows/csi-proxy` |
| `image.csiproxy.tag` | csiproxy docker image tag | `v1.1.2` |
| `image.csiproxy.pullPolicy` | csiproxy image pull policy | `IfNotPresent` |

## troubleshooting
Expand Down
Binary file modified charts/latest/csi-driver-smb-v0.0.0.tgz
View file
Binary file not shown.
3 changes: 2 additions & 1 deletion charts/latest/csi-driver-smb/values.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ image:
tag: v2.8.0
pullPolicy: IfNotPresent
csiproxy:
repository: ghcr.io/kubernetes-sigs/sig-windows/csi-provisioner
repository: ghcr.io/kubernetes-sigs/sig-windows/csi-proxy
tag: v1.1.2
pullPolicy: IfNotPresent

Expand Down Expand Up @@ -147,6 +147,7 @@ windows:
dsName: csi-proxy-win # daemonset name
tolerations: {}
affinity: {}
username: "NT AUTHORITY\\SYSTEM"
nodeSelector:
"kubernetes.io/os": windows

Expand Down

0 comments on commit 7bc1087

Please sign in to comment.