Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publication to PyPiTest #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: publication to PyPiTest #23

wants to merge 1 commit into from

Conversation

qdelamea-aneo
Copy link
Contributor

@qdelamea-aneo qdelamea-aneo commented Nov 21, 2024

Motivation

The project workflow dedicated to publishing test versions on test.pypi.org fails when a pull request is updated without adding new commits to the previous ones.

Description

This change fixes this issue by generating a unique version each time the pipeline is run. This solution is a work around that uses setup.py. This is not ideal and a better solution should be implemented when possible. For more details on the reasons for this change, see:

  • this stack overflow thread on the limitations of setuptools_scm.
  • this page in the setuptools-scm documentation describing how to customize a version.

Testing

Tested using the CI.

Impact

Project test versions are available on test.pypi.org for each run of the publish workflow.

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant