feat: session get command now supports multiple ids #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
qdelamea-aneo
requested changes
Jan 27, 2025
AncientPatata
force-pushed
the
ad/session_multiple_ids
branch
from
5967b6a to
1777fb2
Compare
Made said changes. |
qdelamea-aneo
requested changes
Jan 29, 2025
| @base_command | ||
| def session_cancel(endpoint: str, output: str, session_id: str, debug: bool) -> None: | ||
| """Cancel a session.""" | ||
| def session_cancel(endpoint: str, output: str, session_ids: List[str], debug: bool) -> None: |
There was a problem hiding this comment.
Implement the same logic as the one for delete result data with confirmation for each session.
| @base_command | ||
| def session_close(endpoint: str, output: str, session_id: str, debug: bool) -> None: |
There was a problem hiding this comment.
Here again implement the confirmation logic.
| @base_command | ||
| def session_purge(endpoint: str, output: str, session_id: str, debug: bool) -> None: |
There was a problem hiding this comment.
Here again implement the confirmation logic.
| @base_command | ||
| def session_delete(endpoint: str, output: str, session_id: str, debug: bool) -> None: |
There was a problem hiding this comment.
Here again implement the confirmation logic.
qdelamea-aneo
requested changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Other get commands for the CLI support multiple ids, it makes sense to homogonize them.
Description
session getnow supports multiple ids.Testing
Unit tests pass.
Impact
None.
Additional Information
@qdelamea-aneo With the nature of sessions being a less prevalent entity in ArmoniK in comparison to tasks and results, it feels to me like it wouldn't make sense to allow the user to cancel or delete multiple sessions at once. There is no "performance benefit" to it too since the session commands only take in one argument. What do you think ?
Checklist