Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] feat: integration testing #41

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

AncientPatata
Copy link
Contributor

@AncientPatata AncientPatata commented Jan 23, 2025

Motivation

The unit tests do a good job of testing things like serialization, argument parsing and for testing other isolated components. However, we're not able to properly test how the CLI interacts with the ArmoniK.Api.

Description

This PR adds a series of basic tests that execute some ArmoniK.Admin.CLI commands on an ArmoniK cluster and then checks if everything is handled correctly.

Testing

Not applicable.

Impact

We're able to evaluate the correctness of our interactions with an ArmoniK cluster, and will serve as a foundation for future tests.

Additional Information

The tests can be ran locally pytest tests/integration.py on a localhost deployment. There'll be another PR for the github pipeline but because I don't have the privileges to push to main, I have no way of testing said pipeline, hence why it'll be worked on separately.

  • @qdelamea-aneo I need the result command PR to be merged so I can test "Result" commands

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have thoroughly tested my modifications and added tests when necessary.
  • Tests pass locally and in the CI.
  • I have assessed the performance impact of my modifications.

@AncientPatata AncientPatata changed the title feat: integration testing [wip] feat: integration testing Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
627 573 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: c4b8650 by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant