New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: first implementation of statistics #1

Merged

qdelamea-aneo merged 4 commits into main from qd/stats

Mar 6, 2024

Contributor

qdelamea-aneo commented Mar 1, 2024

No description provided.

qdelamea-aneo requested review from ngruelaneo and aneojgurhem

March 1, 2024 10:40

qdelamea-aneo self-assigned this


          feat: first implementation of statistics

d601e05

qdelamea-aneo force-pushed the qd/stats branch from 0088dc9 to d601e05 Compare

March 1, 2024 10:43

ngruelaneo reviewed

View reviewed changes

examples/basic.py Outdated

+                  parser.add_argument("--session-id", "-s", type=str, help="ID of the session")
+                  args = parser.parse_args()
+                  if args.endpoint.startswith("http://"):

Contributor

ngruelaneo Mar 1, 2024

this line is not useful. You just need to use the last one. There are no error if the prefix is not there.

Contributor Author

qdelamea-aneo Mar 6, 2024

The script crashes is the url provided has the "http" prefix.

ngruelaneo reviewed

View reviewed changes

examples/basic.py Outdated Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

examples/basic.py Outdated Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

pyproject.toml Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

src/armonik_analytics/metrics/base.py Outdated Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

src/armonik_analytics/metrics/base.py Outdated Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

src/armonik_analytics/metrics/common.py Outdated Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

src/armonik_analytics/metrics/base.py Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

src/armonik_analytics/metrics/time_series.py Outdated Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

src/armonik_analytics/metrics/time_series.py Outdated Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

src/armonik_analytics/metrics/time_series.py Outdated Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

src/armonik_analytics/metrics/time_series.py Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

src/armonik_analytics/metrics/transitions.py Outdated Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

tests/unit/test_stats.py Show resolved Hide resolved

ngruelaneo reviewed

View reviewed changes

tests/unit/test_stats.py Show resolved Hide resolved

qdelamea-aneo force-pushed the qd/stats branch from 0dceda1 to aebdd66 Compare

March 6, 2024 13:30


          feat: improve statistics implementation

ba7cc3f

qdelamea-aneo force-pushed the qd/stats branch from aebdd66 to ba7cc3f Compare

March 6, 2024 13:33


          fix: fix CI get coverage

52e450a

github-actions bot commented Mar 6, 2024 •

edited

Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
170	167	98%	0%	🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: e3112ff by action🐍


          fix: example prefix handling

e3112ff

ngruelaneo approved these changes

View reviewed changes

qdelamea-aneo merged commit fafe9c6 into main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet