Merge branch 'main' into chore/lint-js

aneoconsulting · Aug 25, 2023 · 37d8ad6 · 37d8ad6
2 parents 9c01cce + 1c36d7c
commit 37d8ad6
Show file tree

Hide file tree

Showing 11 changed files with 66 additions and 62 deletions.
diff --git a/.docs/content/2.usage/use-armonik-api-in-an-angular-app.md b/.docs/content/2.usage/use-armonik-api-in-an-angular-app.md
@@ -43,7 +43,7 @@ npm install -g @angular/cli
 Then, you can create a new Angular App using the following command:
 
 ```bash
-ng new --standalone --routing=false --inline-style --inline-template --skip-tests --style=css --skip-install armonik-api-angular
+ng new --standalone --routing=false --inline-style --inline-template --skip-tests --skip-git --style=css --skip-install --package-manager=pnpm armonik-api-angular
 ```
 
 Then, go to the newly created folder:
@@ -249,7 +249,8 @@ import { NgFor } from '@angular/common';
   // ...
   imports: [
     NgFor
-  ]
+  ],
+  // ...
 })
 ```
 
@@ -330,7 +331,8 @@ Now that you've created our service and our component, you are ready to use them
 First, you need to inject the service in the component:
 
 ```typescript [app.component.ts]
-import { Component } from '@angular/core';
+import { Component, inject } from '@angular/core';
+import { PartitionsGrpcService } from './services/partitions-grpc.service';
 
 @Component({
   providers: [
@@ -377,7 +379,6 @@ export class AppComponent implements AfterViewInit {
           }
         }
       );
-
   }
 }
 ```
@@ -461,17 +462,14 @@ For simplicity, you will update the service directly. In a real world scenario,
 +     page: 0,
 +     pageSize: 10,
 +     sort: {
-+       direction: ListPartitionsRequest.OrderDirection.ORDER_DIRECTION_ASC,
-+       field: ListPartitionsRequest.OrderByField.ORDER_BY_FIELD_ID
++       direction: SortDirection.SORT_DIRECTION_ASC,
++       field: {
++         partitionRawField: {
++           field: PartitionRawEnumField.PARTITION_RAW_ENUM_FIELD_ID
++         }
++       }
 +     },
-+     filter: {
-+       id: '',
-+       parentPartitionId: '',
-+       podMax: 0,
-+       podReserved: 0,
-+       preemptionPercentage: 0,
-+       priority: 0,
-+     }
++     filters: {}
 +   });
 
     return this.#client.listPartitions(options);

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -37,7 +37,7 @@ jobs:
     timeout-minutes: 15
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.ref }}
           fetch-depth: 0
@@ -83,7 +83,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.ref }}
           fetch-depth: 0
@@ -126,7 +126,7 @@ jobs:
     timeout-minutes: 15
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.ref }}
           fetch-depth: 0
@@ -159,7 +159,7 @@ jobs:
       run:
         working-directory: packages/web
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -190,7 +190,7 @@ jobs:
       run:
         working-directory: packages/angular
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -221,7 +221,7 @@ jobs:
       run:
         working-directory: packages/python
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -261,7 +261,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.ref }}
 

diff --git a/.github/workflows/deploy-docs.yml b/.github/workflows/deploy-docs.yml
@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
 
       - run: npm i -g pnpm @antfu/ni
 
@@ -65,7 +65,7 @@ jobs:
     needs: [generate-proto-docs]
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
 
       # Restore API proto documentation
       - name: Cache Generated Docs from Protos

diff --git a/.github/workflows/publish-edge.yml b/.github/workflows/publish-edge.yml
@@ -17,7 +17,7 @@ jobs:
       version: ${{ steps.genver.outputs.version }}
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.head_ref }}
           fetch-depth: 0
@@ -51,7 +51,7 @@ jobs:
           - packages/csharp/ArmoniK.Api.Tests
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.head_ref }}
           fetch-depth: 0
@@ -91,7 +91,7 @@ jobs:
           - packages/csharp/ArmoniK.Api.Worker/ArmoniK.Api.Worker.csproj
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.head_ref }}
           fetch-depth: 0
@@ -119,7 +119,7 @@ jobs:
     name: Release Angular Package
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.head_ref }}
           fetch-depth: 0
@@ -158,7 +158,7 @@ jobs:
     name: Release Web Package
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.head_ref }}
           fetch-depth: 0
@@ -203,7 +203,7 @@ jobs:
       run:
         working-directory: packages/python
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -243,7 +243,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.ref }}
 

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -16,7 +16,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -49,7 +49,7 @@ jobs:
           - packages/csharp/ArmoniK.Api.Worker/ArmoniK.Api.Worker.csproj
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -75,7 +75,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -102,7 +102,7 @@ jobs:
     needs: [verify-versions]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -135,7 +135,7 @@ jobs:
     needs: [verify-versions]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 
@@ -177,7 +177,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           ref: ${{ github.ref }}
 
@@ -201,7 +201,7 @@ jobs:
     needs: [verify-versions]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
         with:
           fetch-depth: 0
 

diff --git a/.github/workflows/validate-docs-generation.yml b/.github/workflows/validate-docs-generation.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
 
       - run: npm i -g pnpm @antfu/ni
 
@@ -39,7 +39,7 @@ jobs:
     name: Lint Markdown
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
 
       - run: npm i -g pnpm @antfu/ni
 
@@ -57,7 +57,7 @@ jobs:
     name: Lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
 
       - run: npm i -g pnpm @antfu/ni
 

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -3,7 +3,7 @@
     "compile_on_save": true,
     "options": [
       "--proto_path=${workspaceRoot}/Protos/V1",
-      "--csharp_out=${workspaceRoot}/gen/csharp"
+      "--csharp_out=${workspaceRoot}/packages/csharp/generated/"
     ]
   },
   "cSpell.words": [

diff --git a/gen/csharp/.gitkeep → packages/csharp/generated/.gitkeep b/gen/csharp/.gitkeep → packages/csharp/generated/.gitkeep
diff --git a/packages/web/package.json b/packages/web/package.json
@@ -42,12 +42,12 @@
     "prepublish": "cp ../../LICENSE ./LICENSE"
   },
   "dependencies": {
-    "protobufjs": "^7.2.4",
+    "protobufjs": "^7.2.5",
     "rxjs": "^7.8.1"
   },
   "devDependencies": {
     "ts-proto": "^1.156.7",
     "tsup": "^7.2.0",
-    "typescript": "^5.1.6"
+    "typescript": "^5.2.2"
   }
 }