feat: Add version in csharp packages (#448)

aneoconsulting · Dec 21, 2023 · b7dbb58 · b7dbb58
2 parents e899200 + 1488d6a
commit b7dbb58
Show file tree

Hide file tree

Showing 11 changed files with 24 additions and 7 deletions.
diff --git a/packages/csharp/ArmoniK.Api.Client.Test/ArmoniK.Api.Client.Tests.csproj b/packages/csharp/ArmoniK.Api.Client.Test/ArmoniK.Api.Client.Tests.csproj
@@ -10,6 +10,7 @@
     <DebugType>Embedded</DebugType>
     <IncludeSymbols>true</IncludeSymbols>
     <PackageVersion>3.14.0</PackageVersion>
+    <Version>3.14.0</Version>
     <Nullable>enable</Nullable>
   </PropertyGroup>
 

diff --git a/packages/csharp/ArmoniK.Api.Client/ArmoniK.Api.Client.csproj b/packages/csharp/ArmoniK.Api.Client/ArmoniK.Api.Client.csproj
@@ -15,6 +15,7 @@
     <AssemblyOriginatorKeyFile>../kp.snk</AssemblyOriginatorKeyFile>
     <Optimize>true</Optimize>
     <PackageVersion>3.14.0</PackageVersion>
+    <Version>3.14.0</Version>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
   </PropertyGroup>
 

diff --git a/packages/csharp/ArmoniK.Api.Common.Channel/ArmoniK.Api.Common.Channel.csproj b/packages/csharp/ArmoniK.Api.Common.Channel/ArmoniK.Api.Common.Channel.csproj
@@ -5,6 +5,7 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <PackageVersion>3.14.0</PackageVersion>
+    <Version>3.14.0</Version>
     <PackageOutputPath>../publish</PackageOutputPath>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>

diff --git a/packages/csharp/ArmoniK.Api.Common/ArmoniK.Api.Common.csproj b/packages/csharp/ArmoniK.Api.Common/ArmoniK.Api.Common.csproj
@@ -15,6 +15,7 @@
     <AssemblyOriginatorKeyFile>../kp.snk</AssemblyOriginatorKeyFile>
     <Optimize>true</Optimize>
     <PackageVersion>3.14.0</PackageVersion>
+    <Version>3.14.0</Version>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
   </PropertyGroup>
 

diff --git a/packages/csharp/ArmoniK.Api.Core/ArmoniK.Api.Core.csproj b/packages/csharp/ArmoniK.Api.Core/ArmoniK.Api.Core.csproj
@@ -17,6 +17,7 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <AssemblyOriginatorKeyFile>../kp.snk</AssemblyOriginatorKeyFile>
     <PackageVersion>3.14.0</PackageVersion>
+    <Version>3.14.0</Version>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
   </PropertyGroup>

diff --git a/packages/csharp/ArmoniK.Api.Mock/ArmoniK.Api.Mock.csproj b/packages/csharp/ArmoniK.Api.Mock/ArmoniK.Api.Mock.csproj
@@ -15,6 +15,7 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <AssemblyOriginatorKeyFile>../kp.snk</AssemblyOriginatorKeyFile>
     <PackageVersion>3.14.0</PackageVersion>
+    <Version>3.14.0</Version>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
   </PropertyGroup>
 

diff --git a/packages/csharp/ArmoniK.Api.Tests/ArmoniK.Api.Worker.Tests.csproj b/packages/csharp/ArmoniK.Api.Tests/ArmoniK.Api.Worker.Tests.csproj
@@ -10,6 +10,7 @@
     <DebugType>Embedded</DebugType>
     <IncludeSymbols>true</IncludeSymbols>
     <PackageVersion>3.14.0</PackageVersion>
+    <Version>3.14.0</Version>
   </PropertyGroup>
 
   <PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">

diff --git a/packages/csharp/ArmoniK.Api.Worker/ArmoniK.Api.Worker.csproj b/packages/csharp/ArmoniK.Api.Worker/ArmoniK.Api.Worker.csproj
@@ -17,6 +17,7 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <AssemblyOriginatorKeyFile>../kp.snk</AssemblyOriginatorKeyFile>
     <PackageVersion>3.14.0</PackageVersion>
+    <Version>3.14.0</Version>
     <GeneratePackageOnBuild>True</GeneratePackageOnBuild>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
   </PropertyGroup>

diff --git a/scripts/update-versions.ts b/scripts/update-versions.ts
@@ -5,7 +5,8 @@ import {
   cppFiles,
   cppPattern,
   csharpFiles,
-  csharpPattern,
+  csharpPatternPackageVersion,
+  csharpPatternVersion,
   jsFiles,
   jsPattern,
 } from './versions/_contants'
@@ -21,9 +22,13 @@ if (args.length === 0) {
 
 const version = args[0]
 
-consola.info('Updating C# projects to ', version)
+consola.info('Updating C# <PackageVersion> projects to ', version)
 csharpFiles.forEach(
-  _readAndReplace(csharpPattern, `<PackageVersion>${version}</PackageVersion>`),
+  _readAndReplace(csharpPatternPackageVersion, `<PackageVersion>${version}</PackageVersion>`),
+)
+consola.info('Updating C# <Version> projects to ', version)
+csharpFiles.forEach(
+  _readAndReplace(csharpPatternVersion, `<Version>${version}</Version>`),
 )
 
 consola.info('Updating JS projects to ', version)

diff --git a/scripts/verify-versions.ts b/scripts/verify-versions.ts
@@ -4,7 +4,8 @@ import {
   cppFiles,
   cppPattern,
   csharpFiles,
-  csharpPattern,
+  csharpPatternPackageVersion,
+  csharpPatternVersion,
   jsFiles,
   jsPattern,
 } from './versions/_contants'
@@ -15,8 +16,10 @@ const [, , ...args] = process.argv
 
 consola.info('Finding JS projects versions')
 jsFiles.forEach(_readAndFind(jsPattern, versions))
-consola.info('Finding C# projects versions')
-csharpFiles.forEach(_readAndFind(csharpPattern, versions))
+consola.info('Finding C# <PackageVersion> projects versions')
+csharpFiles.forEach(_readAndFind(csharpPatternPackageVersion, versions))
+consola.info('Finding C# <Version> projects versions')
+csharpFiles.forEach(_readAndFind(csharpPatternVersion, versions))
 consola.info('Finding Cpp projects versions')
 cppFiles.forEach(_readAndFind(cppPattern, versions))
 

diff --git a/scripts/versions/_contants.ts b/scripts/versions/_contants.ts
@@ -1,6 +1,7 @@
 import { glob } from 'glob'
 
-export const csharpPattern = /<PackageVersion>(?<version>.*)<\/PackageVersion>/
+export const csharpPatternPackageVersion = /<PackageVersion>(?<version>.*)<\/PackageVersion>/
+export const csharpPatternVersion = /<Version>(?<version>.*)<\/Version>/
 export const csharpFiles = glob.globSync('**/*.csproj')
 
 export const pythonPattern = /version = "(?<version>.*)"/g